Fix loading slide images from a relative directory in tldraw v2 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tldraw v2 code was prepending the origin of the current page to the slide image urls, if they didn't start with "http". This resulted in it generating invalid URLs that look like: https://example.compresentation/ea5b16cd4eef022e866b1462aed02a43342a80a8-1726509771537/svgs/slide1.svg when the playback is compiled to load from a relative URL (i.e. with `REACT_APP_NO_ROUTER=1 PUBLIC_URL=.` ) The cause appears to be that some dead code (assignment to an unused variable) was copied from the tldraw v1 code, and then code later in the file was adjusted to use that variable, making its behaviour differ from tldraw v1. Remove the unused code from tldraw v1, and adjust tldraw v2 to match the behaviour of tldraw v1.
danielpetri1
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tldraw v2 code was prepending the origin of the current page to the slide image urls, if they didn't start with "http". This resulted in it generating invalid URLs that look like:
https://example.compresentation/ea5b16cd4eef022e866b1462aed02a43342a80a8-1726509771537/svgs/slide1.svgwhen the playback is compiled to load from a relative URL (i.e. withREACT_APP_NO_ROUTER=1 PUBLIC_URL=.)The cause appears to be that some dead code (assignment to an unused variable) was copied from the tldraw v1 code, and then code later in the file was adjusted to use that variable, making its behaviour differ from tldraw v1.
Remove the unused code from tldraw v1, and adjust tldraw v2 to match the behaviour of tldraw v1.