Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tldraw to alpha.25 #279

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

danielpetri1
Copy link
Collaborator

What does this PR do?

Upgrades the Tldraw version used by bbb-playback to v2.0.0-alpha.25.

Closes

#277

@antobinary
Copy link
Member

Hi @danielpetri1 ! Thank you for the PR!
Here in one step you do:

  1. upgrade tldraw* dependency
  2. add "recharts" and "styled-components" dependencies
  3. bump up the version of bbb-playback to be ready for tagging

Could you write a couple of notes about 2) please -- is this part of the "fix"? I would have thought that they'd only be needed in package-lock.json if they were transient dependencies needed by tldraw...

@danielpetri1
Copy link
Collaborator Author

danielpetri1 commented Sep 23, 2024

Hi @antobinary, thanks for already taking a look at the PR!

You're right that recharts and styled-components are needed by Tldraw to display the polls and are listed as dependencies there.

I did not expect to need to add them explicitly in package.json here, but without doing so I get the following message when deploying:

Failed to compile.

Module not found: Error: Can't resolve 'styled-components' in '/home/bigbluebutton/bbb-playback/node_modules/@bigbluebutton/tldraw/dist-esm/lib/shapes/poll/components'

Any ideas on why that could be?
If I understood you correctly, they should be listed in package.json but not package-lock.json?

@antobinary
Copy link
Member

I just checked in https://github.com/bigbluebutton/bigbluebutton/blob/v3.0.x-release/bigbluebutton-html5/package.json and I see the same 2 dependency added at the same level (parallel to tldraw in package.json). Good to go, thank you!

@antobinary antobinary merged commit a1feced into bigbluebutton:develop Sep 23, 2024
1 check passed
@danielpetri1 danielpetri1 deleted the tldraw-alpha-25 branch September 23, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants