Prettier poll result #245
Prettier poll result #245
Conversation
|
This does look much nicer! |
|
Please try with other locales. I tested it only with Japanese locale. |
|
I realised that on Webkit browsers including Firefox it did not work perfectly even though quite improved... needs more investigations... |
|
I think the problems are all fixed. Safari and Firefox show the poll correctly. |
|
Well, I've found the on Ubuntu the full block character is not really the same size with digit characters. Needs a bit more tweaking.. |
copied from BBB
copied from BBB
|
Now Chrome on Linux works perfectly. Firefox on Linux is much better, but not perfect. This issue seems more complicated than I thought... |
There was a problem hiding this comment.
Great PR, I just have a minor thing to point out:
In this test I did, the beginning of the bar is slightly off, maybe it has something to do with the different spaces, I don't know. If there is no way to make it aligned, I'd say no problem.
Also, there is the other comments I left out
| @@ -40,6 +42,8 @@ const FULL_BLOCK = '█'; | |||
| const LEFT_HALF_BLOCK = '▌'; | |||
| const RIGHT_HALF_BLOCK = '▐'; | |||
| const EMPTY_BLOCK = '-'; | |||
| const FIGURE_SPACE = ' '; | |||
| const EN_SPACE = ' ' | |||
There was a problem hiding this comment.
Just out of curiosity, what is the difference between the EN and the Figure spaces?
There was a problem hiding this comment.
After some experiment, I've found FIGURE_SPACE does not work for Firefox and EN_SPACE is better. I don't know the difference in detail, but by definition EN_SPACE is 1/2 em. And FIGURE_SPACE should have the same size of digit zero of a fixed font. However, there are somebody saying that it's not guaranteed....
|
@GuiLeme , what is the OS and browser that you found the unaligned poll bar? |
Co-authored-by: Guilherme Pereira Leme <[email protected]>
|
@hiroshisuga, It was a chrome (chrome version 114.0.5735.133, I don't know if this is an important information) on ubuntu 22.04 |
|
Hi @GuiLeme , unfortunately, I cannot reproduce the phenomenon on my Ubuntu 22.04 with Chrome and Brave. It could be a locale problem... |
src/utils/data/index.js
Outdated
| const getPads = (n) => { | ||
| if (deviceInfo.osName === "Linux") { | ||
| if (browserInfo.isChrome) { | ||
| return FIGURE_SPACE.repeat(n); |
There was a problem hiding this comment.
@GuiLeme , can you try change it either to
return FULL_BLOCK.repeat(n);
or
return EN_SPACE.repeat(n);
and check if your problem persists?
There was a problem hiding this comment.
Hey, @hiroshisuga, I tested with both as requested and the EN_SPACE worked pretty well!! here is the result:
The other one, FULL_BLOCK, didn't work, it broke the alignment even more.
Could you test if the EN_SPACE works for you as well? And then, perhaps remove the browser verification on line 73, because the same EN_SPACE goes for Firefox.
There was a problem hiding this comment.
Hi @GuiLeme , in my Ubuntu box (22.04) it (EN_SPACE) did not work. With Brave browser it look like:
It could be a locale problem (though I am using English).... let me leave it here and wait for bug reports.
There was a problem hiding this comment.
@hiroshisuga, Hum, yeah, there must be a problem with locale, I don't think mine is set to English. But as I said, I guess it is just fine the way it is. I don't think this should be a blocking problem.
Let's see what @antobinary thinks about this. I guess everything is fine! If everyone agrees, I can approve the PR!
|
Thank you both! |
Before:
After:
, expecting having more than 100 votes in an option is rare, and a question having more than 10 options would not happen.Update -> use more general algorithm, so that more than 10 question options and more than 100 votes are allowed, even though it would not happen for now (it may happen in the future, who knows..)
