Replace ReactDOM.render with createRoot #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version of react has been bumped upto 18, therefore change to New Root API is required. reactwg/react-18#5
|
Hmmm, thanks for pointing that out. Have you already signed BigBlueButtons's CLA ? |
|
I have submitted the signed agreement, just now. Forgot to do it beforehand 😄 |
pedrobmarin
added a commit
to bigbluebutton/bigbluebutton
that referenced
this pull request
Jul 9, 2022
## What's Changed * feat(playback): move react-scripts to devDependencies by @frankemax in bigbluebutton/bbb-playback#199 * Add regional fallbacks for all languages by @MBM1607 in bigbluebutton/bbb-playback#201 * Replace ReactDOM.render with createRoot by @MBM1607 in bigbluebutton/bbb-playback#200 * chore: locales from upstream by @pedrobmarin in bigbluebutton/bbb-playback#204 * feat(whiteboard): add tldraw support by @germanocaumo in bigbluebutton/bbb-playback#205 ## New Contributors * @frankemax made their first contribution in bigbluebutton/bbb-playback#199 * @MBM1607 made their first contribution in bigbluebutton/bbb-playback#201 **Full Changelog**: bigbluebutton/bbb-playback@v4.0.0...v5.0.0-alpha.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version of react has been bumped upto 18, therefore change to
New Root API is required.
reactwg/react-18#5