Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename incorrect post_excerpt argument in User fixture #100

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Rename incorrect post_excerpt argument in User fixture #100

merged 1 commit into from
Jul 25, 2022

Conversation

over-engineer
Copy link
Contributor

Description

Closes #99 - renames the post_excerpt user data argument to description in the User fixture.

Change Log

  • Rename post_excerpt to description in the User fixture.

Types of changes (if applicable):

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist (if applicable):

  • Meets provided linting standards.

@over-engineer
Copy link
Contributor Author

Hey! 👋

This PR changes a single word – post_excerpt to description. With that being said, this could potentially be a breaking change because all users will be generated with a (biographical) description. That might break things for a test that depends on a user not having a description (i.e. the default behavior up until now).

If you believe this change might be risky, I'd suggest removing the post_excerpt from the user's default values altogether since it's not applicable to a User fixture (see wp_insert_user()).

@ampersarnie ampersarnie changed the base branch from master to release/1.0.0 July 6, 2022 10:51
@ampersarnie ampersarnie added this to the v1.0.0 milestone Jul 6, 2022
Copy link
Contributor

@PaulREnglish PaulREnglish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can't imagine there being many (if any) tests that depend on a default user not having a biographical description.

@ampersarnie ampersarnie merged commit b483e73 into bigbite:release/1.0.0 Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect 'post_excerpt' user argument in User fixture - maybe 'description'?
3 participants