Skip to content

Revamp weight #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ark930 merged 1 commit into from
Sep 9, 2021
Merged

Revamp weight #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions runtime/bifrost/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,7 +969,7 @@ parameter_types! {
pub const SlotLength: BlockNumber = 8u32 as BlockNumber;
pub const XcmTransferOrigin: TransferOriginType = TransferOriginType::FromRelayChain;
pub XcmWeight: XcmBaseWeight = XCM_WEIGHT.into();
pub ContributionWeight:XcmBaseWeight = XCM_WEIGHT.into();
pub ContributionWeight:XcmBaseWeight = 893125000.into();
Copy link
Copy Markdown
Contributor

@herryho herryho Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this ContributionWeight for? And where does 893125000 come from? Can't this weight be covered by the 2 x XcmBaseWeight fee?
Besides, can you also elaborate what the follwoing item 1, 2, 3 represent?

I want to make sure we charge the right amount of transaction fee from the users. So please help to confirm the above information. Thanks!

image

pub AddProxyWeight:XcmBaseWeight = XCM_WEIGHT.into();
pub ConfirmMuitiSigAccount: AccountId = hex!["d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d"].into();
pub RelaychainSovereignSubAccount: MultiLocation = create_x2_parachain_multilocation(ParachainDerivedProxyAccountType::Salp as u16);
Expand All @@ -979,7 +979,7 @@ parameter_types! {

impl bifrost_salp::Config for Runtime {
type BancorPool = Bancor;
type BifrostXcmExecutor = BifrostXcmAdaptor<XcmRouter, XcmWeight, IdentityFee<Balance>>;
type BifrostXcmExecutor = BifrostXcmAdaptor<XcmRouter, XcmWeight, WeightToFee>;
type Event = Event;
type LeasePeriod = LeasePeriod;
type MinContribution = MinContribution;
Expand Down