Fix linter warnings (#18)

Co-authored-by: Alexey Alter-Pesotskiy <“[email protected]”>
bielikb · Dec 30, 2021 · bcf9211 · bcf9211
1 parent 9708634
commit bcf9211
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/lib/fastlane/plugin/create_xcframework/actions/create_xcframework_action.rb b/lib/fastlane/plugin/create_xcframework/actions/create_xcframework_action.rb
@@ -72,8 +72,7 @@ def self.create_xcframework(params)
       end
 
       def self.debug_symbols(index:, params:)
-        return '' unless Helper.xcode_at_least?('12.0.0') 
-        return '' if params[:include_debug_symbols] == false
+        return '' if !Helper.xcode_at_least?('12.0.0') || params[:include_debug_symbols] == false
 
         debug_symbols = []
 

diff --git a/spec/fastlane_create_xcframework_action_spec.rb b/spec/fastlane_create_xcframework_action_spec.rb
@@ -190,7 +190,6 @@
 
       it 'verifies debug_symbols method when xcode version is less than 12' do
         allow(Fastlane::Helper).to receive(:xcode_at_least?).and_return(false)
-        # params = { include_debug_symbols: true }
         result = described_class.debug_symbols(index: 0, params: {})
         expect(result).to eq('')
       end
@@ -226,7 +225,7 @@
         allow(Dir).to receive(:exist?).and_return(true)
         allow(Dir).to receive(:children).and_return([test_data])
         allow(Fastlane::Helper).to receive(:xcode_at_least?).and_return(true)
-        result = described_class.debug_symbols(index: 0, params: { })
+        result = described_class.debug_symbols(index: 0, params: {})
         expected_result = "-debug-symbols #{test_data}/#{test_data}.dSYM -debug-symbols #{test_data}"
         expect(result).to eq(expected_result)
       end