-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: 0.9 #432
WIP: 0.9 #432
Conversation
…o yarikoptic-enh-sorted
One minor thing that is not working for me is that I used to pay |
|
Another minor API change: Otherwise all my |
Glad to hear everything is passing; this was even smoother than 0.8! |
Yeah, great job keeping the API fairly stable. |
Any objections to merging this, @adelavega @effigies @yarikoptic? |
I haven't had a chance to figure out what's going on with FitLins reports, but I'll just require |
LGTM! |
@tyarkoni Any progress on this? It seems that pybids is stalling a bit. :) |
@hjmjohnson yes, plenty of progress—see the commit history for the branch. |
Also, @hjmjohnson, your clock may be off, because you're commenting from the future ;) |
Okay, unless there are any last-minute objections, I'm merging this today. If we catch any issues after the fact, we can release 0.9.1 in short order. |
sorry for the delay -- gimme a day to test just a bit more |
Okay no worries. |
This is a major refactoring of the codebase that addresses #422 by replacing pretty much the entire existing storage/querying code with the SQLAlchemy ORM. I've tried to minimize API changes, but the nature of the changes here made that impossible in some places (e.g., as a trivial example, SQLAlchemy reserves the
.metadata
property on models, so we now haveBIDSFile.get_metadata()
instead).Closes #430.
Closes #431.
Closes #422.
Closes #404.
Closes #398.
Closes #383 (I think).
Closes #232.
Closes #273.
Closes #346.
Closes #402.
Closes #435.