Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility with ia 5.0.3 #339

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

DigitalDwagon
Copy link
Contributor

No description provided.

@vxbinaca
Copy link
Collaborator

Tell me where I'm doing something wrong here:

git clone [email protected]:DigitalDwagon/tubeup.git

cd tubeup

❯ pipx install . --include-deps
⚠️  File exists at /home/vxbinaca/.local/bin/normalizer and points to
    /home/vxbinaca/.local/share/pipx/venvs/requests/bin/normalizer, not
    /home/vxbinaca/.local/share/pipx/venvs/tubeup/bin/normalizer. Not modifying.
⚠️  File exists at /home/vxbinaca/.local/bin/yt-dlp and points to
    /home/vxbinaca/.local/share/pipx/venvs/yt-dlp/bin/yt-dlp, not
    /home/vxbinaca/.local/share/pipx/venvs/tubeup/bin/yt-dlp. Not modifying.
⚠️  File exists at /home/vxbinaca/.local/share/man/man1/yt-dlp.1 and points to
    /home/vxbinaca/.local/share/pipx/venvs/yt-dlp/share/man/man1/yt-dlp.1, not
    /home/vxbinaca/.local/share/pipx/venvs/tubeup/share/man/man1/yt-dlp.1. Not modifying.
  installed package tubeup 2023.8.19, installed using Python 3.12.7
  These apps are now globally available
    - ia
    - jsondiff
    - jsonpatch
    - jsonpointer
    - tqdm
    - tubeup
    - normalizer (symlink missing or pointing to unexpected location)
    - yt-dlp (symlink missing or pointing to unexpected location)
  These manual pages are now globally available
    - man1/yt-dlp.1 (symlink missing or pointing to unexpected location)

Okay so normalizer and yt-dlp aren't grabbed, so I injected them into the venv.

I run your fork:

tubeup https://www.youtube.com/watch\?v\=dBUYstuPvdc
Traceback (most recent call last):
  File "/home/vxbinaca/.local/bin/tubeup", line 8, in <module>
    sys.exit(__main__())
             ^^^^^^^^^^
TypeError: 'module' object is not callable

New error. Typo or my problem?

Fixes compatibility with internetarchive>=5.0.3 by using a custom parser for the --metadata parameter instead of relying on the one (formerly) used by internetarchive

Closes bibanon#338
@DigitalDwagon
Copy link
Contributor Author

re-open after github automatically closed this

@vxbinaca
Copy link
Collaborator

It works, merging. Thank you very much young lady.

@vxbinaca vxbinaca merged commit 120bf3e into bibanon:master Nov 13, 2024
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants