-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add usenetrc argument for ydl_opts to allow the oauth plugin to work. #331
Conversation
I'm seeing reports that oauth is not a guarantee. yt-dlp/yt-dlp#10085 Have you tested this? Can you show the results of the test? |
it is still working for me and downloaded 8 videos so far but i will stop it because i do not want my account banned |
fix your linting so the unit tests work and I'll merge and cut a new version. |
sorry didn't mean to close pr and reopen. i don't know what i'm doing, this is my first pr ever someone fixed the linting so it should be ok now |
no, the unit tests are still failing. You have to update the dictionaries in the test programs to have the new option as well. |
oh ok thank you. i'll get on that
…On Thu, Aug 22, 2024, 8:36 PM Paper ***@***.***> wrote:
no, the unit tests are still failing. You have to update the dictionaries
in the test programs to have the new option as well.
—
Reply to this email directly, view it on GitHub
<#331 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFY3LT3XFE67IVQJOFAPR7DZSYORNAVCNFSM6AAAAABM427YOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGI4TMNZUGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
added the option to the test dicts |
Okay our unit tests are stopping because of the scrape prevention. Your fix is easy enough to understand and will probably not break things, but I want you to rip a video with your branch, post the mirrored item URL here, and then add a commit to this branch updating the instructions to exactly reproduce the steps needed to get all of this to work and I'll merge. You're not changing much here so it's liekly safe to merge and cut a new version for in terms of code. Documentation needs and update tho. |
Note: I'm going to be separating out the |
here is the mirrored item ripped with this branch: |
added instructions to work around the youtube blacklisting
fixed readme syntax
added instructions in the readme. |
with the reports that say oauth is not a guarantee, and will get you banned anyways, i dont think you should merge. unless you see other benefits to allow users to authenticate using a ,netrc file |
The extractor output in item names Edit: I made an issue on plugin maintainers page we'll see what happens. |
couldn't the maintainer of the plugin just make it a general oauth2 script and not have it site specific? |
Turns out it's a relic of youtube-dls system. |
@111100001 Are you okay with closing this? |
yeah thats fine |
see https://github.com/111100001/tubeup
oauth plugin: https://github.com/coletdjnz/yt-dlp-youtube-oauth2
some yt-dlp users might get their ip blacklisted and youtube will show "Sign in to confirm you’re not a bot. This helps protect our community. Learn more" error
a workaround for this issue is using a yt-dlp plugin (plugin link above)
the argument will have no effect and will be ignored if the ~/.netrc config file does not exist