Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add usenetrc argument for ydl_opts to allow the oauth plugin to work. #331

Closed
wants to merge 5 commits into from

Conversation

111100001
Copy link

@111100001 111100001 commented Aug 21, 2024

see https://github.com/111100001/tubeup
oauth plugin: https://github.com/coletdjnz/yt-dlp-youtube-oauth2

some yt-dlp users might get their ip blacklisted and youtube will show "Sign in to confirm you’re not a bot. This helps protect our community. Learn more" error

a workaround for this issue is using a yt-dlp plugin (plugin link above)

the argument will have no effect and will be ignored if the ~/.netrc config file does not exist

@vxbinaca
Copy link
Collaborator

I'm seeing reports that oauth is not a guarantee. yt-dlp/yt-dlp#10085

Have you tested this? Can you show the results of the test?

@111100001
Copy link
Author

it is still working for me and downloaded 8 videos so far

but i will stop it because i do not want my account banned

yt-dlp/yt-dlp#10792 (comment)

@vxbinaca
Copy link
Collaborator

fix your linting so the unit tests work and I'll merge and cut a new version.

111100001

This comment was marked as duplicate.

@111100001 111100001 closed this Aug 22, 2024
@111100001 111100001 reopened this Aug 22, 2024
@111100001
Copy link
Author

111100001 commented Aug 22, 2024

sorry didn't mean to close pr and reopen.

i don't know what i'm doing, this is my first pr ever

someone fixed the linting so it should be ok now

@mrpapersonic
Copy link
Collaborator

no, the unit tests are still failing. You have to update the dictionaries in the test programs to have the new option as well.

@111100001
Copy link
Author

111100001 commented Aug 22, 2024 via email

@111100001
Copy link
Author

added the option to the test dicts

@vxbinaca
Copy link
Collaborator

vxbinaca commented Aug 22, 2024

Okay our unit tests are stopping because of the scrape prevention. Your fix is easy enough to understand and will probably not break things, but I want you to rip a video with your branch, post the mirrored item URL here, and then add a commit to this branch updating the instructions to exactly reproduce the steps needed to get all of this to work and I'll merge.

You're not changing much here so it's liekly safe to merge and cut a new version for in terms of code. Documentation needs and update tho.

@vxbinaca
Copy link
Collaborator

Note: I'm going to be separating out the yt-dlp and tubeup venvs so they won't be combined and will be more manageable from now on

@111100001
Copy link
Author

here is the mirrored item ripped with this branch:

https://archive.org/details/youtube-oauth2-njX2bu-_Vw4

added instructions to work around the youtube blacklisting
fixed readme syntax
@111100001
Copy link
Author

added instructions in the readme.

@111100001
Copy link
Author

with the reports that say oauth is not a guarantee, and will get you banned anyways, i dont think you should merge. unless you see other benefits to allow users to authenticate using a ,netrc file

@vxbinaca
Copy link
Collaborator

vxbinaca commented Aug 31, 2024

The extractor output in item names youtube-oauth2 will break scripts Archive.org staff use to automatically organize videos into the Mirrortube collection, as well as bisect the dataset. Can you fix item name creation?

Edit: I made an issue on plugin maintainers page we'll see what happens.

@vxbinaca
Copy link
Collaborator

couldn't the maintainer of the plugin just make it a general oauth2 script and not have it site specific?

@vxbinaca
Copy link
Collaborator

Turns out it's a relic of youtube-dls system.
coletdjnz/yt-dlp-youtube-oauth2#35 (comment)

@vxbinaca
Copy link
Collaborator

@111100001 Are you okay with closing this?

@111100001
Copy link
Author

yeah thats fine

@vxbinaca vxbinaca closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants