Remove unneeded dependency #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrpapersonic let me double check, I think this might have been an internetarchive lib dependency. |
|
Whatever issue was previously present due to the urllib3 dep in https://github.com/jjjake/internetarchive seems to have abated based on tests passing in this PR. @mrpapersonic Can you confirm via testing with this branch that with this dependency removed nothing breaks? |
I just tested uploading with this branch, and it looks like it works: https://archive.org/details/youtube-hoXJ0ki94fI |
|
@mrpapersonic Thank you! |
|
I'll cut a new version in a sec thanks guys |
|
Thanks @vxbinaca! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use urllib3 at all, so this shouldn't break anything.