Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate tags_string until it fits in 255 bytes #286

Merged
merged 4 commits into from
May 28, 2023

Conversation

yzqzss
Copy link
Contributor

@yzqzss yzqzss commented May 28, 2023

IA's subject field has a 255 bytes length limitation.

IA's subject field has a 255 bytes length limit
@brandongalbraith
Copy link
Collaborator

@yzqzss Looks good 👍 would you mind adding a test for this?

@yzqzss
Copy link
Contributor Author

yzqzss commented May 28, 2023

@yzqzss Looks good +1 would you mind adding a test for this?

OK.

@yzqzss yzqzss marked this pull request as draft May 28, 2023 20:07
@yzqzss yzqzss marked this pull request as ready for review May 28, 2023 20:16
@vxbinaca
Copy link
Collaborator

vxbinaca commented May 28, 2023

If this works I'll push a new version because I don't want the character limitation and I want to finally switch to date versioning.

Edit: It's passing I'll cut a new version tonight. Good find @yzqzss .

@vxbinaca vxbinaca merged commit 6e7f62e into bibanon:master May 28, 2023
@yzqzss yzqzss deleted the subject-255-bytes branch May 29, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants