Reference schema properties from another schema

[IlonaShishov]

Signed-off-by: Ilona Shishov [email protected]

Hi,
While implementing the following APIs, I found that model 'RetrieveStatusResponse' was missing the 'CustomerRelationshipStatus' property.
Also I found that a conversion from openapi to protobuf-schema using openapi-generator results in incorrect auto referencing to other unrelated schemas due to similar property groups.
As a solution to this behavior, I suggest to replace the property groups inside several schemas with a reference to a base schema.

Best regards,
Ilona Shishov

[arnabbian]

Signed-off-by: Ilona Shishov [email protected]

While implementing the following APIs, I found that model 'RetrieveStatusResponse' was lacking the 'CustomerRelationshipStatus' property. Also, a conversion from openapi to protobuf-schema using openapi-generator results in incorrect auto referencing to other unrelated schemas due to similar property groups. As a solution to this behavior, I suggest to replace the property groups inside several schemas with a reference to a base schema.

Hi,
Many thanks for you feedback. We are considering this and will get back to you soon.

Kind regards,
BIAN

[IlonaShishov]

Signed-off-by: Ilona Shishov [email protected]
While implementing the following APIs, I found that model 'RetrieveStatusResponse' was lacking the 'CustomerRelationshipStatus' property. Also, a conversion from openapi to protobuf-schema using openapi-generator results in incorrect auto referencing to other unrelated schemas due to similar property groups. As a solution to this behavior, I suggest to replace the property groups inside several schemas with a reference to a base schema.

Hi, Many thanks for you feedback. We are considering this and will get back to you soon.

Kind regards, BIAN

Thank you

[arnabbian]

Signed-off-by: Ilona Shishov [email protected]
While implementing the following APIs, I found that model 'RetrieveStatusResponse' was lacking the 'CustomerRelationshipStatus' property. Also, a conversion from openapi to protobuf-schema using openapi-generator results in incorrect auto referencing to other unrelated schemas due to similar property groups. As a solution to this behavior, I suggest to replace the property groups inside several schemas with a reference to a base schema.

Hi, Many thanks for you feedback. We are considering this and will get back to you soon.
Kind regards, BIAN

Thank you

Hi Ilona,
We have now reviewed this Pull Request at BIAN.

We agree with your proposed changes, and this will be updated in our Core BIAN model, and available in the next BIAN Release.

For the time being, we recommend you progress with this change in your implementations, as necessary, and the next Release of BIAN will reflect this change.

Many thanks for your feedback, and please feel free to get back in touch with any other points you would like to raise.

Kind regards,
BIAN