-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make loader to always behave as stripdeclarations=true
#104
Labels
Comments
Just tested this. Here’s the Codepen I used for testing. It includes two sets of Both sets of images work OK in latest Edge, Chrome, Firefox and IE. To keep options simple, I’d probably deprecate this option and remove it later. What do you think? |
Thank you for the demo pen!
I completely agree on removing that option.
It will be major release just in case this is a breaking change for some
folks.
…On Dec 1, 2017 5:49 AM, "Ivan Akulov" ***@***.***> wrote:
Just tested this.
Here’s the Codepen I used for testing. It includes two sets of img and div
with background-image – one with a XML declaration, and another without
it: https://codepen.io/iamakulov/pen/KybaEQ
Both sets of images work OK in latest Edge, Chrome, Firefox and IE. To
keep options simple, I’d probably deprecate this option and remove it with
the next major version. What do you think?
*Microsoft EdgeHTML 16.16299*
[image: image]
<https://user-images.githubusercontent.com/2953267/33464179-17a9c9cc-d652-11e7-8b4e-0188e143b835.png>
*Google Chrome 64.0.3281.0 (Official Build) canary (64-bit)*
[image: image]
<https://user-images.githubusercontent.com/2953267/33464285-8da85d0a-d652-11e7-90ac-3d3ef35e3b03.png>
*Firefox 58.0b7 (64-bit)*
[image: image]
<https://user-images.githubusercontent.com/2953267/33464216-47f2ec30-d652-11e7-80ba-05cf9876cb38.png>
*Internet Explorer 11.64.16299.0 (update versions: 11.0.48)*
[image: image]
<https://user-images.githubusercontent.com/2953267/33464255-67d89950-d652-11e7-8a7d-4c677893ad5e.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#104 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHGvCu_ba37iRZpQ6QCQeJS16SuJmW0wks5s71sLgaJpZM4OHnHu>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to test if SVG without XML declaration works ok in all modern browsers, including IE11 and Edge.
And if this is the case,
stripdeclarations
option can be removed and set to true to make it a default behaviour of the loader.cc @malthejorgensen
The text was updated successfully, but these errors were encountered: