Skip to content

Service Accounts Settings And Configuration Files #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2019

Conversation

bhardwajaditya
Copy link
Owner

Modules Added:

  • Settings for Service Accounts
  • User approval process to create service accounts

service-account-settings

Copy link
Collaborator

@kb0304 kb0304 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor indentation changes in template, everything else seems good to go 👍

<div class="content">
{{#unless hasPermission}}
<p>{{_ "You_are_not_authorized_to_view_this_page"}}</p>
{{else}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some indentation issues in this file.

@bizzbyster bizzbyster merged commit 8b5a9b5 into service-accounts Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants