Skip to content

feat: add tacthub sdk #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

feat: add tacthub sdk #3

wants to merge 23 commits into from

Conversation

westside
Copy link
Contributor

No description provided.

@westside westside self-assigned this Jan 25, 2024
Laeyoung
Laeyoung reviewed Jan 26, 2024
View reviewed changes
Copy link

@Laeyoung Laeyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App에서 Server 실행 시킨 후에 Python 쪽 실행 시키고 나서,
connection 메세지를 받은 이후에 양쪽에서 Crash가 발생해서 테스트는 못해 보았습니다ㅠ

스크린샷 2024-01-26 오후 12 10 26

@Laeyoung
Copy link

Notion 가이드 문서는 괜찮은거 같아요!

@auejin
Copy link

auejin commented Jan 26, 2024

실험 조건

  • 파이썬 3.12.0의 venv내 requirements.txt 설치.
  • 동일한 wifi 내 택헙 앱 (debug=False)과 파이썬 클라이언트 실행.

실험 결과

  • 스페이스 바 누를 때마다 이벤트 재생 되는 것 확인함.
  • stopByEventId는 작동을 안함.
  • play_event서 offset_angle_x가 적용이 안됨.

참고 사항

  • RequestAuthInit시 "요청한 주소는 해당 컨텍스트에서 유효하지 않습니다"가 뜨나 python client가 crash되지는 않음.
  • 해당 오류 이후에도 햅틱 이벤트는 문제 없이 잘 재생됨.

image

cc @Laeyoung @westside

westside and others added 19 commits January 26, 2024 18:45
@westside
fix: minor update
a99134d
@westside
Update README.md
f8dde3e
@westside
fix: remove whitespace
7a86971
@laeyoung-bhaptics @westside
feat: remove stop_by_event(), and stop_all()
df1be05 
# Conflicts:
#	bhaptics/haptic_player.py
#	sample.py
@laeyoung-bhaptics
fix: remove reassigned default values
623c48f
@westside
Update README.md
d7ee6db
@laeyoung-bhaptics
feat: add play_dot_mode method
8f0f86d
@laeyoung-bhaptics
feat: add play_path_mode method (not working well)
e885442
@laeyoung-bhaptics
feat: update path mode sample and update comments
ca38888
@Laeyoung
Merge pull request #6 from bhaptics/feat/dot-and-path-mode
5fe060a 
Feat/dot and path mode
@laeyoung-bhaptics
Update README.md
da657b9
@auejin-bhaptics
feat: make readme more readable
6f36eea
@auejin-bhaptics
Merge pull request #7 from bhaptics/feat/tacthub-update-readme
f3c0ed5 
feat: make readme more readable
@auejin-bhaptics
refactor: tcp_client, udp_server
b39153b
@auejin-bhaptics
refactor: haptic_player
c5c08c3
@auejin-bhaptics
feat: implement ping loop
0e72c40
@auejin-bhaptics
chore: change marker when event is finished
ee3b979
@auejin-bhaptics
Merge pull request #8 from bhaptics/feat/tacthub-refactor
857fb8b 
feat: refactor tacthub
@auejin-bhaptics
fix: bug of not starting the ping thread
75f372d
@auejin auejin self-assigned this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Laeyoung Laeyoung Laeyoung left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@westside westside

@auejin auejin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@westside @Laeyoung @auejin @laeyoung-bhaptics @auejin-bhaptics