Skip to content

comet_ml validation images #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

comet_ml validation images #944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion helpers/training/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,7 +1236,15 @@ def _log_validations_to_webhook(

def _log_validations_to_trackers(self, validation_images):
for tracker in self.accelerator.trackers:
if tracker.name == "wandb":
if tracker.name == "comet_ml":
experiment = self.accelerator.get_tracker("comet_ml").tracker
for shortname, image_list in validation_images.items():
for idx, image in enumerate(image_list):
experiment.log_image(
image,
name=f"{shortname} - {self.validation_resolutions[idx]}",
)
elif tracker.name == "wandb":
resolution_list = [
f"{res[0]}x{res[1]}" for res in get_validation_resolutions()
]
Expand Down
Loading