Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log images as a normal log entry so you get a slider that lets you see past images #731

Closed
AmericanPresidentJimmyCarter opened this issue Aug 11, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pending This issue has a fix that is awaiting test results.

Comments

@AmericanPresidentJimmyCarter

I log them like this, which will give you a slider and let you see past images:

            formatted_images = []

            for log in image_logs:
                images = log["images"]
                validation_prompt = log["prompt"]
                validation_image = log.get("validation_image", None)

                for image in images:
                    image = wandb.Image(image, caption=validation_prompt)
                    formatted_images.append(image)

            tracker.log({"validation": formatted_images})
@bghira
Copy link
Owner

bghira commented Aug 11, 2024

but it doesn't handle multi-resolution or multi-image-per-prompt validations like the table mode does. maybe there's some wandb docs on how to get a table slider.

@bghira bghira added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 11, 2024
@AmericanPresidentJimmyCarter
Copy link
Author

I think we can probably just automatically log as a list of images if the images are square, and if they aren't just log the way it currently does.

@AmericanPresidentJimmyCarter
Copy link
Author

And yeah, step slider for table is an open issue: wandb/wandb#6286

@bghira
Copy link
Owner

bghira commented Aug 13, 2024

but you can change the res list and then the table shows up with a 2nd list.. i just want the table to work really

@bghira
Copy link
Owner

bghira commented Aug 25, 2024

see #872

@bghira bghira added the pending This issue has a fix that is awaiting test results. label Aug 25, 2024
@bghira bghira closed this as completed Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pending This issue has a fix that is awaiting test results.
Projects
None yet
Development

No branches or pull requests

2 participants