Skip to content

Commit

Permalink
[api][dist] Update haml_lint gem
Browse files Browse the repository at this point in the history
Previous version caused some errors after upgrading to Rails 5.
This gets solved with version 0.26 of haml_lint and also updates the
haml lint conf.

===

undefined method `each' for nil:NilClass
/usr/lib64/ruby/gems/2.4.0/gems/haml_lint-0.24.0/lib/haml_lint/linter/class_attribute_with_static_value.rb:33:in `contains_class_attribute?'
/usr/lib64/ruby/gems/2.4.0/gems/haml_lint-0.24.0/lib/haml_lint/linter/class_attribute_with_static_value.rb:24:in
  • Loading branch information
bgeuken committed Jun 21, 2017
1 parent 73da109 commit 0aa36f2
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 12 deletions.
20 changes: 16 additions & 4 deletions src/api/.haml-lint_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `haml-lint --auto-gen-config`
# on 2017-05-19 18:34:24 +0200 using Haml-Lint version 0.24.0.
# on 2017-06-21 12:38:23 +0200 using Haml-Lint version 0.26.0.
# The point is for the user to remove these configuration records
# one by one as the lints are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand All @@ -12,18 +12,30 @@ linters:
ConsecutiveSilentScripts:
enabled: false

# Offense count: 331
# Offense count: 335
LineLength:
enabled: false

# Offense count: 99
# Offense count: 107
RuboCop:
enabled: false

# Offense count: 152
SpaceInsideHashAttributes:
enabled: false

# Offense count: 64
InlineStyles:
enabled: false

# Offense count: 4
ViewLength:
exclude:
- "app/views/webui/monitor/_events.html.haml"
- "app/views/webui/monitor/_workers_table.html.haml"
- "app/views/webui/patchinfo/_form.html.haml"
- "app/views/webui/user/show.html.haml"

# Offense count: 1
MultilineScript:
exclude:
Expand Down Expand Up @@ -70,4 +82,4 @@ linters:
HtmlAttributes:
exclude:
- "app/views/webui/user/_dropdown_menu.html.haml"
- "app/views/webui/user/index.html.haml"
- "app/views/webui/user/index.html.haml"
2 changes: 1 addition & 1 deletion src/api/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ group :development, :test do
# for style checks
gem 'rubocop', require: false
# integrates with RuboCop to analyse HAML files
gem 'haml_lint', '~> 0.24.0'
gem 'haml_lint'
# to generate random long strings
gem 'faker'
# as driver for capybara
Expand Down
17 changes: 10 additions & 7 deletions src/api/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,11 @@ GEM
ffi (>= 1.0.1)
haml (4.0.7)
tilt
haml_lint (0.24.0)
haml_lint (0.26.0)
haml (>= 4.0, < 5.1)
rainbow
rake (>= 10, < 13)
rubocop (>= 0.47.0)
rubocop (>= 0.49.0)
sysexits (~> 1.1)
hashdiff (0.3.0)
hoptoad_notifier (2.4.11)
Expand Down Expand Up @@ -195,7 +195,8 @@ GEM
nokogiri
nyan-cat-formatter (0.11)
rspec (>= 2.99, >= 2.14.2, < 4)
parser (2.3.3.1)
parallel (1.11.2)
parser (2.4.0.0)
ast (~> 2.2)
path_expander (1.0.1)
peek (0.2.0)
Expand Down Expand Up @@ -257,7 +258,8 @@ GEM
method_source
rake (>= 0.8.7)
thor (>= 0.18.1, < 2.0)
rainbow (2.2.1)
rainbow (2.2.2)
rake
raindrops (0.17.0)
rake (12.0.0)
rantly (1.1.0)
Expand Down Expand Up @@ -287,7 +289,8 @@ GEM
rspec-mocks (~> 3.5.0)
rspec-support (~> 3.5.0)
rspec-support (3.5.0)
rubocop (0.47.1)
rubocop (0.49.1)
parallel (~> 1.10)
parser (>= 2.3.3.1, < 3.0)
powerpack (~> 0.1)
rainbow (>= 1.99.1, < 3.0)
Expand Down Expand Up @@ -346,7 +349,7 @@ GEM
thread_safe (~> 0.1)
uglifier (3.0.1)
execjs (>= 0.3.0, < 3)
unicode-display_width (1.1.3)
unicode-display_width (1.3.0)
unicorn (5.1.0)
kgio (~> 2.6)
raindrops (~> 0.7)
Expand Down Expand Up @@ -403,7 +406,7 @@ DEPENDENCIES
font-awesome-rails
gssapi
haml (~> 4.0)
haml_lint (~> 0.24.0)
haml_lint
hoptoad_notifier (~> 2.3)
jquery-datatables-rails
jquery-rails
Expand Down

0 comments on commit 0aa36f2

Please sign in to comment.