Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asterisk 10, 11, 13, 14 compatibility fixes. And a few other fixes. #216

Open
wants to merge 137 commits into
base: master
Choose a base branch
from

Commits on Sep 5, 2015

  1. Parse a +CMGS notification and hack it to send an event with reference.

    Author: me, some time in the past.
    Source: /~dexter/work/asterisk-chan-dongle/patch.patch.txt
    wdoekes committed Sep 5, 2015
    Configuration menu
    Copy the full SHA
    d13f113 View commit details
    Browse the repository at this point in the history
  2. Add Asterisk 10 support.

    Author: me, some time in the past.
    Source: /~dexter/work/asterisk-chan-dongle/patch2.patch.txt
    wdoekes committed Sep 5, 2015
    Configuration menu
    Copy the full SHA
    ea62b24 View commit details
    Browse the repository at this point in the history
  3. Add more Asterisk 10 support.

    Author: me, some time in the past.
    Source: /~dexter/work/asterisk-chan-dongle/patch3.patch.txt
    wdoekes committed Sep 5, 2015
    Configuration menu
    Copy the full SHA
    aebd073 View commit details
    Browse the repository at this point in the history
  4. Add Asterisk 11 support.

    Author: me, in August 2013.
    wdoekes committed Sep 5, 2015
    Configuration menu
    Copy the full SHA
    9108a96 View commit details
    Browse the repository at this point in the history
  5. Add .gitignore.

    wdoekes committed Sep 5, 2015
    Configuration menu
    Copy the full SHA
    46cc1dd View commit details
    Browse the repository at this point in the history
  6. Add Asterisk 13 support.

    Author: novaktmp, 2014-12-01 17:42:52
    Source: https://forum.openwrt.org/viewtopic.php?id=54343
    
    Slight adaptations by me.
    wdoekes committed Sep 5, 2015
    Configuration menu
    Copy the full SHA
    50110f3 View commit details
    Browse the repository at this point in the history
  7. Translate NUL to @ in incoming SMS.

    Author: mio
    Source: bg111#153
    
    Not using full 3GPP version from https://code.google.com/p/
      asterisk-chan-dongle/issues/detail?id=140 because of the issues
    described there.
    
    This should simply fix that you don't get a truncated SMS because of an
    @ sign.
    wdoekes committed Sep 5, 2015
    Configuration menu
    Copy the full SHA
    897b27c View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2015

  1. Configuration menu
    Copy the full SHA
    cd03d3a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7eb9b85 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2015

  1. Configuration menu
    Copy the full SHA
    5801434 View commit details
    Browse the repository at this point in the history
  2. Move ASTERISK_VERSION_NUM setting to ./configure invocation:

    Now do:
    
        ./configure --with-astversion=110102
    
    if you have Asterisk version 11.1.2.
    wdoekes committed Sep 20, 2015
    Configuration menu
    Copy the full SHA
    1cf0f4b View commit details
    Browse the repository at this point in the history
  3. Fix channel unlock issue in Asterisk >= 12.

    Thanks @bg111 for the review.
    wdoekes committed Sep 20, 2015
    Configuration menu
    Copy the full SHA
    6e28278 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6dad123 View commit details
    Browse the repository at this point in the history
  5. build: Properly force a recompile on config.h change.

    Also move the ASTERISK_VERSION_NUM to config.h.
    wdoekes committed Sep 20, 2015
    Configuration menu
    Copy the full SHA
    c5c0c5d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c3490bb View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2015

  1. Clarify --with-astversion parameter in ./configure.

    As suggested by @arekm. Note that "010813" does not work, as gcc will treat
    it as base 8.
    wdoekes committed Dec 25, 2015
    Configuration menu
    Copy the full SHA
    db3c629 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2016

  1. Configuration menu
    Copy the full SHA
    53e0be5 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2016

  1. Don't crash ongoing calls when receiving SMS.

    According to the bug report by Marcelo Fernandes Vianna:
    > Under some circumstances (if parsing the sms returns -1 in
    > at_response.c), even if sms is disabled in dongle.conf,
    > receiving a sms can still crash an ongoing call.
    
    Thanks for the suggested patch. Refactored and merged.
    Closes #7.
    wdoekes committed Sep 4, 2016
    Configuration menu
    Copy the full SHA
    c2d9c34 View commit details
    Browse the repository at this point in the history
  2. Fix compile issues with Asterisk 14.

    Declare AST_MODULE_SELF_SYM=__internal_$(module_name)_self.
    wdoekes committed Sep 4, 2016
    Configuration menu
    Copy the full SHA
    9529a68 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2016

  1. Fix decoding of SMS with non-language characters.

    Character conversion assumed UCS-2, which handles only the Basic
    Multilingual Plane, but various parties will have switched to using
    UTF-16 there.
    
    Fix suggested by @fadasi. Reported and tested by @pjmichel. Thanks!
    Closes #8.
    wdoekes committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    bf38e68 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2016

  1. Configuration menu
    Copy the full SHA
    15f2a39 View commit details
    Browse the repository at this point in the history
  2. Support TON=5 with any NPI (instead of just 0) for alphanumeric address.

    @fadasi observed addresses with 0xD0 and 0xD1 (NPI is UNKNOWN or E164)
    in the wild. Fix comparisons to only check the TON.
    
    Closes #9.
    wdoekes committed Oct 1, 2016
    Configuration menu
    Copy the full SHA
    39c3e04 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #11 from bg111/master

    Merge fixes from upstream bg111/asterisk-chan-dongle
    wdoekes authored Oct 1, 2016
    Configuration menu
    Copy the full SHA
    51c9cec View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2016

  1. Merge pull request #10 from wdoekes/number_type_alnum_d0_d1

    Allow D0 and D1 for addresses
    
    Tested by @fadasi. Thanks!
    wdoekes authored Oct 2, 2016
    Configuration menu
    Copy the full SHA
    c1109d6 View commit details
    Browse the repository at this point in the history
  2. Fix so compilation with different include dirs work.

    Now you can do this:
    
        ./configure --with-astversion=140000 \
            --with-asterisk=$HOME/src/asterisk-14/include
        make clean all
    
    And:
    
        ./configure --with-astversion=10800 \
            --with-asterisk=$HOME/src/asterisk-1.8/include
        make clean all
    
    Etc..
    wdoekes committed Oct 2, 2016
    Configuration menu
    Copy the full SHA
    c24a315 View commit details
    Browse the repository at this point in the history
  3. Add travis file.

    wdoekes committed Oct 2, 2016
    Configuration menu
    Copy the full SHA
    6f316d1 View commit details
    Browse the repository at this point in the history
  4. Build fix for Asterisk 12.

    wdoekes committed Oct 2, 2016
    Configuration menu
    Copy the full SHA
    a2c6a24 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8c657be View commit details
    Browse the repository at this point in the history
  6. Merge branch 'travis'

    wdoekes committed Oct 2, 2016
    Configuration menu
    Copy the full SHA
    1e60445 View commit details
    Browse the repository at this point in the history
  7. Unbreak compiled module loading broken in c24a315.

    Fixes #15 but doesn't explain it yet.
    wdoekes committed Oct 2, 2016
    Configuration menu
    Copy the full SHA
    428a746 View commit details
    Browse the repository at this point in the history
  8. Better fix for breakage from c24a315.

    Closes #15.
    wdoekes committed Oct 2, 2016
    Configuration menu
    Copy the full SHA
    dcf4f68 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2016

  1. Adds a DongleSendUSSD function (Device, USSD) dialplan function

    Inspired from http://a.dmin.pro/?p=2712 (presumably October 4, 2011 by arturius)
    Also adds DongleSendUSSD and DongleSendSMS dialplan functions examples
    
    For more visibility and traceability, the unmodified code style has not been changed
    fadasi committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    e221694 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #16 from fadasi/master

    Adds a DongleSendUSSD function (Device, USSD) dialplan function
    
    Thanks @fadasi!
    wdoekes authored Oct 6, 2016
    Configuration menu
    Copy the full SHA
    eeb503a View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2016

  1. Clarify ./bootstrap procedure. Drop ancient INSTALL docs.

    Clarifies the "no makefile.am" problem from #18, but doesn't fix it.
    wdoekes committed Nov 13, 2016
    Configuration menu
    Copy the full SHA
    2a5a097 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2017

  1. bootstrap: Fix file naming (not 'bootstap').

    Reported by @k008 in ghwdoekes/asterisk-chan-dongle issue #20.
    wdoekes committed Jan 20, 2017
    Configuration menu
    Copy the full SHA
    283f399 View commit details
    Browse the repository at this point in the history
  2. build: Improve --with-astversion to take X.Y.Z version.

    This should clarify a few things.
    wdoekes committed Jan 20, 2017
    5 Configuration menu
    Copy the full SHA
    8bbba90 View commit details
    Browse the repository at this point in the history
  3. build: Explain that you may use --with-asterisk on configure.

    Closes ghwdoekes/asterisk-chan-dongle issue #20.
    wdoekes committed Jan 20, 2017
    Configuration menu
    Copy the full SHA
    5b99b75 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    48df4f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2017

  1. pdu/tests: Clean up pdu_parse if-tree and restore test capability.

        make check
    
    to build and run tests.
    
    Cleanups were required to even begin attempting to fix #28.
    wdoekes committed Apr 16, 2017
    Configuration menu
    Copy the full SHA
    fba6ed1 View commit details
    Browse the repository at this point in the history
  2. pdu/tests: Add tests for multipart 7bit encoded message decoding.

    See bug #13. This creates stub tests. They're disabled, since it's
    broken at the moment.
    wdoekes committed Apr 16, 2017
    Configuration menu
    Copy the full SHA
    2152a58 View commit details
    Browse the repository at this point in the history
  3. char_conv: Handle 7bit encoded multi-part SMS correctly.

    Most of this patch was taken from:
    bg111#183
    ==>
    bg111#214
    
    Some changes were elided because:
    - of uncertainty of their workings
    - they did not improve the results of the available tests
    
    ----
    
    From 2aba9dd Mon Sep 17 00:00:00 2001
    From: Rodrigo Freire <[email protected]>
    Date: Fri, 28 Aug 2015 16:10:20 -0300
    Subject: [PATCH] Resolves bg111#183
    
    From: HPS <[email protected]>
    From: Shabbira <[email protected]>
    
    Subject: Parses correctly multi-part SMS messages
    Comitter: Rodrigo Freire <[email protected]>
    Signed-off-by: Rodrigo Freire <[email protected]>
    
    This patch was retrieved from
    https://code.google.com/p/asterisk-chan-dongle/issues/detail?id=183
    Now parses correctly multi-part SMS Messages. Verified on a Huawei
    E303S.
    
    ----
    
    Closes #13.
    wdoekes committed Apr 16, 2017
    Configuration menu
    Copy the full SHA
    9f32405 View commit details
    Browse the repository at this point in the history
  4. pdu/parsing: Fix unsupported DCS value 0xF0.

    Closes #28.
    wdoekes committed Apr 16, 2017
    Configuration menu
    Copy the full SHA
    9c10081 View commit details
    Browse the repository at this point in the history
  5. docs: Add note about avoiding "SMS-injection".

    Closes #24. Thanks Lynxie (@lnx13) for the report.
    wdoekes committed Apr 16, 2017
    Configuration menu
    Copy the full SHA
    212ea86 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e324cfe View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    704deed View commit details
    Browse the repository at this point in the history
  8. decoding: Decode 7bit alphabet to unicode.

    A better fix than the previous @ replacement in 897b27c.
    wdoekes committed Apr 16, 2017
    Configuration menu
    Copy the full SHA
    b0a2dec View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2017

  1. cleanup: Fix a few typo's.

    wdoekes committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    7c8e6b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14a966d View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2017

  1. cleanup/fix: Undo pvt=NULL "fix" which was bad.

    Fixes #30 I think.
    wdoekes committed Apr 18, 2017
    Configuration menu
    Copy the full SHA
    45d8fbc View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2017

  1. cleanup: Remove leftover round_robin_mtx comments.

    It appears there previously was a global round_robin struct that had to
    be mutex protected, but it has been refactored to use locally scoped vars
    instead.
    wdoekes committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    d6c2982 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    78a2e97 View commit details
    Browse the repository at this point in the history
  3. fix: Fix incidental deadlock with Jitterbuffer or Asterisk 12+.

    Closes #19, reported by @vitasgul, @multijohn and Garrone Joseph
    (@garronej).
    
    Cause found through diligent bug reporting and testing by Garrone.
    wdoekes committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    c929b35 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2017

  1. Configuration menu
    Copy the full SHA
    b6c7fdf View commit details
    Browse the repository at this point in the history
  2. Merge pull request #34 from garronej/master

    Add instructions for applying Jitter buffer and automatic gain control
    
    Thanks @garronej!
    wdoekes authored Jun 1, 2017
    Configuration menu
    Copy the full SHA
    217daf4 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2017

  1. Ignore """+CMTI: "SM",-1""" with negative index.

    Instead of disconnecting a standing call, we ignore the message.
    
    Closes #35. Requested by @vitasgul.
    wdoekes committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    c57ef0d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e452f7 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2017

  1. Fix audio endianess problem on big endian systems.

    This fixes broken audio from asterisk toward the GSM network. Issue was
    originally reported here: openwrt/telephony#7.
    Github user @ljakob provided this patch and reports success:
    
    (Sep 9, 2015)
    > Hi, I've used the patch over the last month on my box and it works
    > perfectly. Audio gain from my old x86 installation had to be copied but
    > that was expected. There have been at least 100 calls without any
    > problems.
    
    Signed-off-by: Sebastian Kemper <[email protected]>
    Code cleaned up by wdoekes.
    
    Closes #42.
    micmac1 authored and wdoekes committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    53e83a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d1a86f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2017

  1. Revert "fix Sparc loud noise problem bg111#201"

    This reverts commit ab93953.
    
    Apparently there was too much byteswapping (on big-endian machines)
    going on with both ab93953 and 53e83a4. Reverting ab93953 appears to
    work for @Infactum.
    
    Closes #44.
    wdoekes committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    4ef5ad7 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Lower default timeout of 2sec to 5sec and 15sec to 40sec

    This should probably fix call drop issues with E3131A modem (same as
    E303).
    
    I cannot quickly find documentation about what the timeout "should" be,
    but using 3 timeout classes with short/medium/long makes more sense to
    me than having the classes defined by the duration.
    
    Please report any issues that arise from this change.
    
    Suggested-by: @mthqwork
    Closes: #50
    wdoekes committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    8c14e40 View commit details
    Browse the repository at this point in the history
  2. Improve asterisk/modules dir autodetection

    Previously ./configure would continue after not finding DESTDIR for the
    module and then fail at 'make install'. Now it requires you to set
    DESTDIR if autodetection fails. Also added lib64 in the default paths to
    try.
    
    Reported-by: @alaa2003
    Closes: #49
    wdoekes committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    cfab716 View commit details
    Browse the repository at this point in the history
  3. Hide -Wimplicit-fallthrough= false positives

    gcc apparently groks "/* fall through */" as well as __attribute__
    ((fallthrough)) which probably is not supported on all compilers.
    wdoekes committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    fe2861e View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2018

  1. pdu/parsing: Fix unsupported DCS value 19

    After looking at specs from
    http://www.3gpp.org/ftp//Specs/archive/23_series/23.038/ it looks like
    it should allow more than we did.
    
    Closes #41 (I think).
    wdoekes committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    bf0e955 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ba9cf2 View commit details
    Browse the repository at this point in the history
  3. travis: Unbreak CI

    wdoekes committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    3e2b3ca View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2018

  1. USSD encoding fix for E3531

    Huawei E3531 works fine with firmware 21.318.29.00.769, voice and sms, except USSD.
    Adding it to seven_bit_modems[] solves issue. (#56)
    grray authored and wdoekes committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    fd544d6 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Add with-iconv

    misuzu authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    4e16d96 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Trim trailing garbage from provider name causing ast_json_vpack error

    The AT+COPS command has been observed to return similar but different
    provider names. Sometimes with a trailing illegal character, or a
    trailing @.
    
    Dongle make/model E1550 (patched for voice support), identified by Linux
    as "Huawei Technologies Co., Ltd. E161/E169/E620/E800 HSDPA Modem".
    
    Example output:
    
        AT+COPS?
        +COPS: 0,2,"25020",2
    
        AT+COPS=?
        +COPS: (2,"TELE2 RU","TELE2 RU","25020",2),
               (1,"MTS-RUS","MTS","25001",2),
               (1,"Beeline","Beeline","25099",2),
               (1,"MegaFon)
    
        AT+COPS=?
        +COPS: (2,"TELE2 RU","TELE2 RU","25020",2),
               (1,"MegaFon RUS","MegaFon","25002",2),
               (1,"Beeline","Beeline","25099",2),
               (1,)
    
        AT+COPS=?
        +COPS: (2,"Tele2@","Tele2�","25020",2),
               (1,"MTS-RUS","MTS","25001",2),
               (1,"Beeline","Beeline","25099",2),
               (1,"MegaFon RUS)
    
    (that replacement character (U+FFFD) is probably something else; likely a
    single octet in the >=128 range)
    
    A dongle change (same make/model) did not help. A simcard change did not
    help. Likely culprit for now seems to be the provider (Russian Tele2?).
    
    This changeset drops trailing "@" and trailing non-printables from the
    provider name. It would still switch from "TELE2 RU" to "Tele2", but not
    to something with unreadable characters.
    
    Closes #39.
    
    This also fixes this error:
    
        json.c:607 ast_json_vpack: Error building JSON from '{s: s, s: s}':
          Invalid UTF-8 string.
    
    Generated at:
    
        for (idx = 0; idx < ITEMS_OF(dev_vars); ++idx) {
            # dev_vars[1] == { "DONGLEPROVIDER", pvt->provider_name }
            pbx_builtin_setvar_helper(channel, dev_vars[idx].name,
                                      dev_vars[idx].value);
        }
    
    Because newer Asterisken use JSON to publish these messages, and that
    character (which isn't U+FFFD) is illegal UTF-8.
    
    Closes #69.
    
    Thanks go to sergio (@532910) for debugging and testing this issue.
    wdoekes committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    62259b2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e08f0d4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2067262 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8b1827c View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. Configuration menu
    Copy the full SHA
    c0bfc32 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. Merge pull request #72 from misuzu/with-iconv

    Add --with-iconv option to specify a different path
    wdoekes authored Dec 17, 2019
    Configuration menu
    Copy the full SHA
    24bf23c View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2020

  1. Disable Asterisk 1.8 travis test

    It's old, and conflicts with #75
    wdoekes committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    923db63 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2020

  1. Configuration menu
    Copy the full SHA
    fe3b185 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f46dd16 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1161b7c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2983cab View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2020

  1. Merge pull request #75 from magcks/master

    Concatenated SMS support; Complete locking and single shift tables.
    
    Thanks Max von Buelow!
    wdoekes authored Feb 19, 2020
    Configuration menu
    Copy the full SHA
    ee17874 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Rename enque to enqueue, and remove fishy function pointer casts

    The casting of functions taking fewer parameters than were given
    probably did work on most platforms with common calling conventions. But
    the calling convention is not defined by us. And the C-style cast
    removes all other sanity checks as well.
    wdoekes committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    1815ddd View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. Configuration menu
    Copy the full SHA
    9968d4a View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. E3531 support

    maxvonbuelow committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    cb610d4 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2020

  1. Merge pull request #80 from magcks/E3531s2

    "[ignore] AT+CNUM errors [returned by] E3531s-2"
    
    Thanks @magcks!
    wdoekes authored May 3, 2020
    Configuration menu
    Copy the full SHA
    9e86540 View commit details
    Browse the repository at this point in the history
  2. Add configure.ac checks for sqlite3

    Closes #74, reported by @ruijorgesilva1.
    wdoekes committed May 3, 2020
    Configuration menu
    Copy the full SHA
    a4a7a34 View commit details
    Browse the repository at this point in the history
  3. Fix for stuck SMS.

    It has been observed that CMTI notifications can stop when the internal
    memory of the E1750 dongle is full. Instead an SMMEMFULL indication is received.
    
    This patch includes multiple fixes:
    - Always poll SMS messages during startup.
    - Only poll one SMS message at a time, by keeping a bitmap of polled messages.
    - Only delete message after successful reception.
    
    Assume that no more than 256 SMS's will be stored by the external SIM card.
    
    Signed-off-by: Hans Petter Selasky <[email protected]>
    hselasky committed May 3, 2020
    Configuration menu
    Copy the full SHA
    ba5e721 View commit details
    Browse the repository at this point in the history
  4. Fix bug in SMS parsing logic.

    Try to use length field at beginning of TP-DA, instead of assuming fixed length.
    
    [dongle0] Error parsing incoming message '+CMGR: 0,,24
    06917429000102068E0A917419778290023020020200400230200202004000' at position 70:
    Good report, but delivery failed
    
    Signed-off-by: Hans Petter Selasky <[email protected]>
    hselasky committed May 3, 2020
    Configuration menu
    Copy the full SHA
    413cad9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1d00a5d View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Seperated PDU parsing (and building) into hex parsing, actual PDU dec…

    …oding and UCS-2 decoding; Implemented delivery reports; Fixed USSD generating
    maxvonbuelow committed May 5, 2020
    Configuration menu
    Copy the full SHA
    868bbd4 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Resolved conflicts w/ #79

    maxvonbuelow committed May 14, 2020
    Configuration menu
    Copy the full SHA
    1e5b916 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #77 from magcks/unhexpdu

    Reworked PDU parsing; Delivery reports
    wdoekes authored May 14, 2020
    Configuration menu
    Copy the full SHA
    b18ca62 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. Fixed issue #85

    maxvonbuelow committed May 15, 2020
    Configuration menu
    Copy the full SHA
    71e3206 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #86 from magcks/unhexpdu

    Fixed issue #85
    wdoekes authored May 15, 2020
    Configuration menu
    Copy the full SHA
    7bdef5e View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Use incoming_sms_index field as indication of incoming SMS instead of…

    … incoming_sms.
    
    Signed-off-by: Hans Petter Selasky <[email protected]>
    hselasky committed May 28, 2020
    Configuration menu
    Copy the full SHA
    6f377e7 View commit details
    Browse the repository at this point in the history
  2. Fix compile warning. Ensure enum2str() is declared.

    Signed-off-by: Hans Petter Selasky <[email protected]>
    hselasky committed May 28, 2020
    Configuration menu
    Copy the full SHA
    dd658fb View commit details
    Browse the repository at this point in the history
  3. Fix uninitialized use of res variable.

    Signed-off-by: Hans Petter Selasky <[email protected]>
    hselasky committed May 28, 2020
    Configuration menu
    Copy the full SHA
    0b68e29 View commit details
    Browse the repository at this point in the history
  4. Fix compile warning for clang: Unsequenced modification of i.

    Signed-off-by: Hans Petter Selasky <[email protected]>
    hselasky committed May 28, 2020
    Configuration menu
    Copy the full SHA
    ea421a5 View commit details
    Browse the repository at this point in the history
  5. Remove unused variables.

    Signed-off-by: Hans Petter Selasky <[email protected]>
    hselasky committed May 28, 2020
    Configuration menu
    Copy the full SHA
    d456f22 View commit details
    Browse the repository at this point in the history
  6. Fix compile warnings.

    Signed-off-by: Hans Petter Selasky <[email protected]>
    hselasky committed May 28, 2020
    Configuration menu
    Copy the full SHA
    403ecee View commit details
    Browse the repository at this point in the history
  7. Fix variable type.

    Signed-off-by: Hans Petter Selasky <[email protected]>
    hselasky committed May 28, 2020
    Configuration menu
    Copy the full SHA
    db20b69 View commit details
    Browse the repository at this point in the history
  8. Always receive next SMS regardless of error.

    Signed-off-by: Hans Petter Selasky <[email protected]>
    hselasky committed May 28, 2020
    Configuration menu
    Copy the full SHA
    4426101 View commit details
    Browse the repository at this point in the history
  9. Fix integer to pointer conversion.

    Signed-off-by: Hans Petter Selasky <[email protected]>
    hselasky committed May 28, 2020
    Configuration menu
    Copy the full SHA
    81064ef View commit details
    Browse the repository at this point in the history
  10. Fix regression issue after PDU parsing was separated.

    Signed-off-by: Hans Petter Selasky <[email protected]>
    hselasky committed May 28, 2020
    Configuration menu
    Copy the full SHA
    5110695 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #90 from hselasky/master

    Fixes for regression issues and some improvements.
    
    Thanks Hans Petter Selasky!
    wdoekes authored May 28, 2020
    Configuration menu
    Copy the full SHA
    328b2b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Removed some magic. Sorry, I'm not a wizard

    p-velasco authored and unnamed committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    b8eb673 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Use Asterisk function ast_unescape_c on SMS text when sending via AMI

    This change was warranted because AMI is a text based protocol and the newline can't be included in the payload.
    Standard backslash escape sequences are used, e.g. '\n' for newline and '\t' for tabulator characters.
    miopa authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    fe26c84 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Merge pull request #101 from miopa/patch-2

    Use Asterisk function `ast_unescape_c` on SMS text when sending via AMI
    
    Thanks Damjan Janevski!
    wdoekes authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    9322431 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Add guard against NULL args.payload

    NULL args.payload causes a crash in the call to strlen(args.payload)
    while computing arguments for send_sms.
    phcoder committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    fd04f63 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Merge pull request #99 from phcoder/payload

    Add guard against NULL args.payload
    
    Thanks Vladimir Serbinenko!
    wdoekes authored Jun 19, 2020
    Configuration menu
    Copy the full SHA
    6358664 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. fix ucs-2 empty sms bug

    gituser authored and wdoekes committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    e700abc View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Merge pull request #96 from p-velasco/pin-implementation

    "Removed some magic. Sorry, I'm not a wizard"
    
    Thanks @p-velasco!
    wdoekes authored Jun 25, 2020
    Configuration menu
    Copy the full SHA
    0d1bad5 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2020

  1. Better type safe sms inbox

    gituser committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    4a15ac8 View commit details
    Browse the repository at this point in the history
  2. Suppress errors on initial sms poll

    gituser committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    4652c90 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Merge pull request #107 from 4e4o/master

    Better type safety of SMS handling and error suppression on initial SMS poll.
    
    Thanks @4e4o
    wdoekes authored Aug 19, 2020
    Configuration menu
    Copy the full SHA
    213f677 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Configuration menu
    Copy the full SHA
    bde8838 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. A better change to the logging

    hardillb authored and wdoekes committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    fc4d5d8 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2020

  1. Updated interfaces for E171

    The correct device interfaces for HUAWEI E171 modem is  3,2  . the 1,2 interface order does not work. 
    
    Model: E171
    Firmware: 21.156.00.00.143
    IMEI: 861496015775578
    mghadam authored and wdoekes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    f1517b4 View commit details
    Browse the repository at this point in the history
  2. Added E153Du-1 device id ports

    Updated ports for E153Du-1
    IMEI: 868672001033577
    mghadam authored and wdoekes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    2bd3fc2 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. fix Cannot parse UCS-2 error (#131)

    Thanks @129tyc!
    129tyc authored Apr 19, 2021
    Configuration menu
    Copy the full SHA
    ca9b692 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2021

  1. Abort compilation on warnings

    wdoekes committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    5a0ee53 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    222039f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81b0fda View commit details
    Browse the repository at this point in the history
  4. Fix make check compiler warnings and check errors

    msg had been partially removed in 868bbd4.
    wdoekes committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    a35294b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    427a665 View commit details
    Browse the repository at this point in the history
  6. Better variable locality in at_enqueue_initialization

    (No random "cmd12" constants.)
    wdoekes committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    46be41b View commit details
    Browse the repository at this point in the history
  7. Add Quectel support

    Totally untested. Might close #144.
    
    Based on this patch:
    
        From d332203 Mon Sep 17 00:00:00 2001
        From: Sebastian Kemper <[email protected]>
        Date: Thu, 9 Sep 2021 11:14:30 +0200
        Subject: [PATCH] Dongle to Quectel changes
    
        Signed-off-by: Sebastian Kemper <[email protected]>
        ---
         at_command.c | 4 ++--
         pdiscovery.c | 1 +
         2 files changed, 3 insertions(+), 2 deletions(-)
    
        diff --git a/at_command.c b/at_command.c
        index 4882d82..684e821 100644
        --- a/at_command.c
        +++ b/at_command.c
        @@ -33,7 +33,7 @@ static const char cmd_at[] 	 = "AT\r";
         static const char cmd_chld1x[]   = "AT+CHLD=1%d\r";
         static const char cmd_chld2[]    = "AT+CHLD=2\r";
         static const char cmd_clcc[]     = "AT+CLCC\r";
        -static const char cmd_ddsetex2[] = "AT^DDSETEX=2\r";
        +static const char cmd_ddsetex2[] = "AT+QPCMV=1,0\r";
    
         /*!
          * \brief Format and fill generic command
        @@ -128,7 +128,7 @@ EXPORT_DEF int at_enqueue_initialization(struct cpvt *cpvt, at_cmd_t from_comman
         	static const char cmd15[] = "AT+CREG?\r";
         	static const char cmd16[] = "AT+CNUM\r";
    
        -	static const char cmd17[] = "AT^CVOICE?\r";
        +	static const char cmd17[] = "AT+QPCMV?\r";
         //	static const char cmd18[] = "AT+CLIP=0\r";
         	static const char cmd19[] = "AT+CSSN=1,1\r";
         	static const char cmd20[] = "AT+CMGF=0\r";
        diff --git a/pdiscovery.c b/pdiscovery.c
        index 006c5d8..c599c23 100644
        --- a/pdiscovery.c
        +++ b/pdiscovery.c
        @@ -68,6 +68,7 @@ static const struct pdiscovery_device device_ids[] = {
                 { 0x12d1, 0x14ac, { 4, 3, /* 0 */ } },          /* E153Du-1 : thanks mghadam */
         	{ 0x12d1, 0x1436, { 4, 3, /* 0 */ } },		/* E1750 */
         	{ 0x12d1, 0x1506, { 3, 2, /* 0 */ } },		/* E171 firmware 21.x : thanks Sergey Ivanov */
        +	{ 0x2c7c, 0x0125, { 1, 4, /* 0 */ } },		/* Dongle EC25-A LTE modem */
         };
    
         static struct discovery_cache cache;
    wdoekes committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    6073c91 View commit details
    Browse the repository at this point in the history
  8. Quick fix for mips-openwrt-linux-musl-gcc maybe-uninitialized warning

    (Definite false positive.)
    wdoekes committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    5837b98 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    df6e3ed View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Remove use_ucs2_encoding (#146)

    It's no longer used
    rojer authored Sep 29, 2021
    Configuration menu
    Copy the full SHA
    5c88561 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'add-quectel-support'

    Non-Quectel tested by Deomid Ryabkov. Also includes better -Werror
    behaviour.
    
    Quectel support untested thusfar. We'll see how that goes.
    wdoekes committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    24e656a View commit details
    Browse the repository at this point in the history
  3. Fix GSM7 decoding on big endian targets (#145)

    The uint16_t bytes are the other way around.
    rojer authored Sep 29, 2021
    Configuration menu
    Copy the full SHA
    3d2a97f View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Do not choke on failed AT^CVOICE? or AT+QPCMV? during startup

    ATQ_CMD_DECLARE_STI adds ATQ_CMD_FLAG_IGNORE so the error response on
    either command does not abort the entire initialization task.
    
    Without it, we migh get:
    
        [AT+QPCMV?]
        remove command 'AT+QPCMV' expected response 'OK' real 'ERROR' cmd
          16/22 flags 0x01 from queue
        remove task with 22 command(s) begin with 'AT' expected response
          'OK' from queue
    
    where the failed AT+QPCMV? aborts the 22-item init task.
    
    Closes #148, reported and tested by @AlexHighTower.
    wdoekes committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    3d046f7 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Remove probably-useless code at voice init failure

    > i think these lines can also be removed, since ATQ_CMD_DECLARE_STI
    > will plow ahead anyway, no need to manually restart the sequence.
    
    Dixit, @rojer in #148. I don't know. Sounds plausible.
    wdoekes committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    5a9cdc9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f73a2b3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7378810 View commit details
    Browse the repository at this point in the history
  4. Fix formatting in error.h

    wdoekes committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    57e025d View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Revert "Updated interfaces for E171"

    This reverts commit f1517b4.
    
    See discussion on:
    f1517b4
    
    There @Vald3m argues that the old values were correct.
    wdoekes committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    503dba8 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. Consider long long (lld) for time_t (#173)

    Some libc implementations are shifting toward using 64-bit time_t for
    all arches to solve the year 2038 problem. musl is one of them, see [1].
    
    So when compiling for a 32-bit arch time_t will be long long. This
    commit adds this option.
    
    [1] https://musl.libc.org/time64.html
    
    Signed-off-by: Sebastian Kemper <[email protected]>
    micmac1 authored Dec 26, 2023
    Configuration menu
    Copy the full SHA
    13450af View commit details
    Browse the repository at this point in the history