Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use-project with native paths. #318

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Conversation

grafikrobot
Copy link
Member

Proposed changes

It's possible, and common in Boost, to register projects using native paths (usually from env vars). That would cause incorrect tracking of the projects and result in failing to find them. This change converts the native path to a b2 path for registration. Which resolves finding them when it comes to loading the used projects.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I searched the discussions
  • I searched the closed and open issues
  • I read the contribution guidelines
  • I added myself to the copyright attributions for significant changes
  • I checked that tests pass locally with my changes
  • I added necessary documentation (if appropriate)

It's possible, and common in Boost, to register projects using native paths (usually from env vars). That would cause incorrect tracking of the projects and result in failing to find them. This change converts the native path to a b2 path for registration. Which resolves finding them when it comes to loading the used projects.
@grafikrobot grafikrobot added bug Something isn't working backport version/4.10.0 Backport to release 4.10.0 labels Jun 3, 2023
@grafikrobot grafikrobot self-assigned this Jun 3, 2023
@grafikrobot grafikrobot merged commit 09d8d07 into main Jun 3, 2023
@grafikrobot grafikrobot deleted the grafikrobot-patch-2 branch June 3, 2023 16:36
@grafikrobot
Copy link
Member Author

/backport

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Successfully created backport PR for version/4.10.0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version/4.10.0 Backport to release 4.10.0 bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant