Refine error code of ErrBkWriteRequest #1060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tovi163 <[email protected]> Refine the ErrBkWriteRequest to ErrBkWriteRequestByBackend and ErrBkWriteRequestClient
|
Need to fix the DCO problem first. |
iyangsj
requested changes
Jul 9, 2022
| request.ErrMsg = err.Error() | ||
| p.proxyState.ErrBkWriteRequest.Inc(1) | ||
| p.proxyState.ErrBkWriteRequestByClient.Inc(1) |
There was a problem hiding this comment.
这里还未确定错误的具体原因（由client导致 或 backend导致）。因此，不能直接对ErrBkWriteRequestByClient进行计数
| allowRetry = checkAllowRetry(cluster.RetryLevel(), outreq) | ||
|
|
||
| // if error is caused by backend server | ||
| rerr := err.(bfe_http.WriteRequestError) | ||
| if !rerr.CheckTargetError(request.RemoteAddr) { | ||
| request.ErrCode = bfe_basic.ErrBkWriteRequestByBackend | ||
| p.proxyState.ErrBkWriteRequestByBackend.Inc(1) |
There was a problem hiding this comment.
合理的做法是： 删除line 385/line387，在line 396后增加 :
else {
request.ErrCode = bfe_basic.ErrBkWriteRequestByClient
p.proxyState.ErrBkWriteRequestByClient.Inc(1)
}
| @@ -40,7 +40,8 @@ var ( | |||
| ErrBkNoBackend = errors.New("BK_NO_BACKEND") // no backend found | |||
| ErrBkRequestBackend = errors.New("BK_REQUEST_BACKEND") // forward request to backend error | |||
| ErrBkConnectBackend = errors.New("BK_CONNECT_BACKEND") // connect backend error | |||
| ErrBkWriteRequest = errors.New("BK_WRITE_REQUEST") // write request error (caused by bk or client) | |||
| ErrBkWriteRequestByBackend = errors.New("BK_WRITE_REQUEST_CAUSED_BY_BACKEND") // write request error (caused by backend) | |||
| ErrBkWriteRequestByClient = errors.New("BK_WRITE_REQUEST_CAUSED_BY_CLIENT") // write request error (caused by client) | |||
There was a problem hiding this comment.
建议:
- 把line 44 ErrBkWriteRequestByClient移动到line33之后（代表client类错误）
- 命名修改下 ErrClientReadRequest
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tovi163 [email protected]
Refine the ErrBkWriteRequest to ErrBkWriteRequestByBackend and ErrBkWriteRequestClient