New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] feat(connector): Add multitenancy support using namespaces. #823

Closed

dhirajsb wants to merge 12 commits into bf2fc6cc711aee1a0c2a:main from dhirajsb:multitenancy_apis

Contributor

dhirajsb commented Mar 1, 2022 •

edited

Loading

Description

Adds support for multiple connector tenants for individual users and organizations.

Verification Steps

Multiple extensive integration tests are included. They should also pass in CI.

Checklist (Definition of Done)

All acceptance criteria specified in JIRA have been completed
Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
Documentation added for the feature
CI and all relevant tests are passing
Code Review completed
Verified independently by reviewer
Required metrics/dashboards/alerts have been added (or PR created).
Required Standard Operating Procedure (SOP) is added.
JIRA has created for changes required on the client side

dhirajsb requested review from chirino, lburgazzoli and valdar

March 1, 2022 20:17

dhirajsb force-pushed the multitenancy_apis branch from 36101a7 to b7410ed Compare

March 1, 2022 20:53

github-actions bot added common connector labels

dhirajsb changed the title ~~[WIP] feat(connector): Add multitenancy support using namespaces.~~ feat(connector): Add multitenancy support using namespaces.

dhirajsb changed the title ~~feat(connector): Add multitenancy support using namespaces.~~ [wip] feat(connector): Add multitenancy support using namespaces.

lburgazzoli reviewed

View reviewed changes

internal/connector/internal/config/connectors.go Outdated Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

internal/connector/internal/environments/stage.go Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

internal/connector/internal/presenters/connector.go Outdated Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

internal/connector/internal/services/connector_cluster.go Outdated Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

internal/connector/test/integration/features/connector-agent-api.feature Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

internal/connector/internal/api/public/model_deployment_location.go Outdated Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

openapi/connector_mgmt.yaml Outdated Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

openapi/connector_mgmt.yaml Outdated Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

openapi/connector_mgmt.yaml Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

openapi/connector_mgmt.yaml Outdated Show resolved Hide resolved

Contributor

lburgazzoli commented Mar 2, 2022

@dhirajsb good work, I added some comments

github-actions bot removed the request for review from lburgazzoli

March 2, 2022 17:59

dhirajsb force-pushed the multitenancy_apis branch 2 times, most recently from 6e91986 to 02051c1 Compare

March 3, 2022 00:19

dhirajsb added 7 commits

March 2, 2022 16:41


          feat(connector): added initial apis for connector namespaces

c5a6d8c


          feat(connectors): replaced cluster with namespace in connector deploy…

48a98d6

…ments, filtering by namespaces in connector queries


          feat(connectors): added /namespaces endpoint to list cluster namespac…

dea6689

…es, added required cluster_id to namespace create request, and support for creating user and org kind namespaces


          fix(connectors): fix missing deleted_at indices

be15bc9


          fix(connectors): replace namespace name with namespace ID in admin up…

dc34871

…grades API


          fix(connectors): fixed connector-eval-duration flag to directly use t…

bda68b8

…ime.Duration


          fix(connectors): removed DeploymentLocation, replaced Tenant discrimi…

27d2731

…nator with enum, removed TargetKind in Connectors table

dhirajsb force-pushed the multitenancy_apis branch from 02051c1 to 27d2731 Compare

March 3, 2022 00:45

dhirajsb added do-not-merge enhancement labels

dhirajsb added 2 commits

March 2, 2022 21:51


          feat(connector): added namespace worker to reap expired namespaces

d4b0113


          fix(connectors): put back validateConnector validation call for conne…

9ce5c97

…ctor patch

lburgazzoli reviewed

View reviewed changes

internal/connector/test/integration/features/connector-multitenancy-api.feature Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

openapi/connector_mgmt.yaml Show resolved Hide resolved

dhirajsb added 2 commits

March 3, 2022 14:37


          fix(connector): fixed namespace update operation by using ConnectorNa…

da0efb9

…mespacePathRequest type


          fix(connectors): made cluster and namespace delete atomic db tx opera…

51f37e3

…tions

valdar requested changes

View reviewed changes

internal/connector/internal/services/connector_namespaces.go Show resolved Hide resolved

internal/connector/internal/services/connector_namespaces.go Show resolved Hide resolved


          fix(connector): typo in namespace delete error message

307aa47

github-actions bot requested a review from valdar

March 4, 2022 18:15

valdar approved these changes

View reviewed changes

Contributor

pb82 commented Mar 8, 2022

@dhirajsb should the wip be removed?

Contributor Author

dhirajsb commented Mar 8, 2022

@dhirajsb should the wip be removed?

@pb82 I'm working on one final change to allow agents to post namespace status. It should be done today.

Contributor Author

dhirajsb commented Mar 8, 2022

Created new PR #841 from a new fork after bf2 repo was made public.

dhirajsb closed this

dhirajsb mentioned this pull request

feat(connector): Add multitenancy support using namespaces. #841

Merged

6 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common connector do-not-merge enhancement