handle when data is undefined (in addEvent
)
#33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
I think there is one problem but it could be either one.
data
parameter inaddEvent
is neededundefined
Code
addEvent("saw image")
this kind of code with thedata
parameter not specified will result in the following error.This is because the
data
parameter itself is undefined.Solution
If documentation needs fixing...
If you don't need any kind of data to be sent, you have to put in
{}
to avoid the error.This is annoying and unnecessary.
I don't think it's the best thing to just enter
{}
if you could enter nothing.If the code needs fixing...
I think it's the best thing to check whether data is defined first.