Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

feat: Remove not stable appender implementation #24

Merged
merged 2 commits into from
Sep 8, 2021
Merged

feat: Remove not stable appender implementation #24

merged 2 commits into from
Sep 8, 2021

Conversation

bokket
Copy link
Member

@bokket bokket commented Sep 8, 2021

Signed-off-by: bokket [email protected]

Signed-off-by: bokket <[email protected]>
@Xuanwo
Copy link
Contributor

Xuanwo commented Sep 8, 2021

The test failed again :(

defer func() {
closeErr := f.Close()
if err == nil {
err = closeErr
}
}()
o = s.newObject(true)
o.ID = rp
o.Path = path
o.Mode = ModeRead | ModeAppend
o.SetAppendOffset(0)
return o, nil

What will happen if the closeErr is not nil?

@Xuanwo
Copy link
Contributor

Xuanwo commented Sep 8, 2021

If the integretion tests of Append failed randomly, I think we need to remove the whole feature instead.

@Xuanwo Xuanwo changed the title docs: Update README feat: Remove not stable appender implementation Sep 8, 2021
@Xuanwo Xuanwo merged commit a971810 into beyondstorage:master Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants