Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Replication fix amendment to #778 #881

Merged
merged 5 commits into from
Jan 5, 2022

Conversation

mdprotacio
Copy link
Contributor

No description provided.

@kloining
Copy link
Contributor

kloining commented Dec 6, 2021

I implemented this PR manually in my repository, and it solved a number of issues:

  • Fixed the stats for a channel, the number could also be a negative number, resulting in a permanent breakdown
  • This resulted in a replica to unsubscribe from redis, stopping broadcasts to the channel on other servers.
    Please get this checked and merged :)

@mpociot
Copy link
Member

mpociot commented Jan 5, 2022

Thank you for the PR @mdprotacio

@mpociot mpociot merged commit 171480d into beyondcode:master Jan 5, 2022
@erikn69
Copy link
Contributor

erikn69 commented Jan 5, 2022

There was 1 failure:

1) BeyondCode\LaravelWebSockets\Test\FetchChannelTest::test_it_returns_404_for_invalid_channels
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
-    'occupied' => true
-    'subscription_count' => 2
+    'occupied' => false
+    'subscription_count' => 0
 )

/home/runner/work/laravel-websockets/laravel-websockets/tests/FetchChannelTest.php:129
phpvfscomposer:///home/runner/work/laravel-websockets/laravel-websockets/vendor/phpunit/phpunit/phpunit:60

@genesiscz
Copy link

This seems to introduce a new problem:

PHP Warning: Undefined property: Ratchet\Server\IoConnection::$lastPongedAt in /data/.../vendor/cboden/ratchet/src/Ratchet/AbstractConnectionDecorator.php on line 31

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants