New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring.SetUnitHealth with build < 1 does not turn units back into nanoframes #1698

Open

GoogleFrog opened this issue Sep 26, 2024 · 0 comments

Labels

Collaborator

GoogleFrog commented Sep 26, 2024

There does not seem to be any way to turn a built unit back into a non-built unit.

This part needs handling for the unit becoming non-finished: https://github.com/beyond-all-reason/spring/blob/master/rts/Lua/LuaSyncedCtrl.cpp#L1997

This part of Unit.cpp successfully reverts units into an inbuild state, but is inaccessible to lua: https://github.com/beyond-all-reason/spring/blob/master/rts/Sim/Units/Unit.cpp#L2039

GoogleFrog mentioned this issue

Dynamic modifier tech issues ZeroK-RTS/Zero-K#5362

Open

lhog added the enhancement label

sprunk added a commit that referenced this issue


          Fix #1698, reverting units to nanoframe via Lua

b6ad2ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment