Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projectile overrange unit implementation attempt 3 #4244

Conversation

SethDGamre
Copy link
Collaborator

@SethDGamre SethDGamre commented Jan 28, 2025

This adds the customparams to the unitdefs of rocket/missile weapons setting the overrange distance to +15%

Why customparams?

  1. lua is expensive. Only add it to units that need it
  2. we don't want this added to undesired units like AA, or weapons that are only technically missiles but look like something else
  3. for performance reasons, raptors should be exempt
  4. easily comprehensible and usable for the balance team to tweak to their hearts content
  5. overrange is different characteristics depending on descent method for the effective maximum range achieved

@SethDGamre SethDGamre added Awaiting BLT Approval Approval needed from the balance team Approved Approved for implementation by the Game Design Team and removed Awaiting BLT Approval Approval needed from the balance team labels Jan 30, 2025
@SethDGamre SethDGamre marked this pull request as ready for review February 22, 2025 17:43
@SethDGamre
Copy link
Collaborator Author

SethDGamre commented Feb 22, 2025

Unit was removed in a previous PR
@Zecrus2 Zecrus2 merged commit 5679f48 into beyond-all-reason:master Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved for implementation by the Game Design Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants