-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bevy_reflect: Unique Reflect
#56
Open
nicopap
wants to merge
7
commits into
bevyengine:main
Choose a base branch
from
nicopap:bevy-reflect-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 02f5777 - Browse repository at this point
Copy the full SHA 02f5777View commit details
Commits on Jun 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e45293e - Browse repository at this point
Copy the full SHA e45293eView commit details
Commits on Jun 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 757173f - Browse repository at this point
Copy the full SHA 757173fView commit details
Commits on Jun 19, 2022
-
Replace
make_canon
withinto_full
This allows us to remove the hard-requirement on `FromReflect` for everything, and also makes the conversion from `Reflect` to `CanonReflect` less compute-intensive.
Configuration menu - View commit details
-
Copy full SHA for 6dc6519 - Browse repository at this point
Copy the full SHA 6dc6519View commit details -
Rename
CanonReflect
and reformulate the problemBy community consensus, `CanonReflect` is now `Reflect` and "old" `Reflect` is now `PartialReflect`. Since we "keep" `Reflect`, I reformulate the change to conceptually fit with the current reference frame. I also explain in more details the concepts `Reflect` represent and make clear what the true underlying source of the awkwardness of `Reflect` is.
Configuration menu - View commit details
-
Copy full SHA for ab3c114 - Browse repository at this point
Copy the full SHA ab3c114View commit details
Commits on Jun 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cd5e84a - Browse repository at this point
Copy the full SHA cd5e84aView commit details
Commits on Jan 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bc7d6db - Browse repository at this point
Copy the full SHA bc7d6dbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.