Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make template a github PR template #2

Closed
wants to merge 1 commit into from

Conversation

aevyrie
Copy link
Member

@aevyrie aevyrie commented Apr 14, 2021

Renaming to make this the github template when creating a new file

Renaming to make this the github template when creating a new file
@DJMcNab
Copy link
Member

DJMcNab commented Apr 14, 2021

I don't think this is quite right - the way that https://github.com/rust-lang/rfcs does this is to have to the template as 000-template.md at the directory root, and then. Also, the RFC text shouldn't be in the pull request description, it should be in the new markdown file.

@cart should we have RFC numbering too? I doubt it's going to get ridiculous, but it wouldn't hurt

@aevyrie
Copy link
Member Author

aevyrie commented Apr 14, 2021

I don't think this is quite right - the way that https://github.com/rust-lang/rfcs does this is to have to the template as 000-template.md at the directory root, and then. Also, the RFC text shouldn't be in the pull request description, it should be in the new markdown file.

@cart should we have RFC numbering too? I doubt it's going to get ridiculous, but it wouldn't hurt

Yeah, I just realized this. Will close.

@aevyrie aevyrie closed this Apr 14, 2021
@aevyrie
Copy link
Member Author

aevyrie commented Apr 14, 2021

Cart commented about numbering earlier - I think we'll plan to leave that out for now as feature/rfc names should be unique.

Edit: bevyengine/bevy#1662 (comment)

I don't see much utility in numbering RFCs. We can already reference them via their "github issue number" and their "unique feature name" (which we require in the title). Ensuring that we increment numbers correctly / avoid collisions feels like wasted effort.

@DJMcNab
Copy link
Member

DJMcNab commented Apr 14, 2021

It's not just about uniqueness - it's useful for ordering/exploring.

Like low number RFCs are past and are expected to be somewhat outdated.

The numbering is assigned based on the GitHub pull request number, which means that

Ensuring that we increment numbers correctly / avoid collisions

is easy because GitHub handles it for us

@aevyrie
Copy link
Member Author

aevyrie commented Apr 14, 2021

I'll create an issue and we can discuss there?

@aevyrie aevyrie mentioned this pull request Apr 14, 2021
@aevyrie aevyrie deleted the patch-1 branch April 14, 2021 21:31
Weibye pushed a commit to Weibye/rfcs that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants