-
Notifications
You must be signed in to change notification settings - Fork 7
wgpu 28 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
wgpu 28 #17
Conversation
|
Before merging, I'd like to make sure we test it. This entry from the wgpu changelog has me a little worried: "Using both the wgpu command encoding APIs and CommandEncoder::as_hal_mut on the same encoder will now result in a panic." |
|
We'll also need to bump and publish v3 of this crate. |
|
yep it is currently panicking when running solari in the bevy repo with "Mixing the wgpu encoding API with the raw encoding API is not permitted". |
|
@ChristopherBiscardi try this 3c34a53. Note that some changes will be needed on Bevy's side as well - feel free to reach out to me over discord and I can assist. |
|
@JMS55 I've updated this PR with that diff, and some additional fixes to get it to compile/fix tests (which is in an additional commit here) bevyengine/bevy@53db3a5 is the bevy-side commit, which runs but the naga-oil enable issue now needs to be solved to confirm it all working. |
Co-authored-by: JMS55 <[email protected]>
…le_fail on examples
currently broken, caused by gfx-rs/wgpu#8373