-
Notifications
You must be signed in to change notification settings - Fork 401
Clarify PR Merging Rules in Contributing Guide #1615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify PR Merging Rules in Contributing Guide #1615
Conversation
|
@lewiszlw could you take a look at this one too? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content looks good to me. But I didn't find the original text of How Pull Requests are merged in main repo.
The original text was in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some grammar nitpicks. Looks good otherwise.
content/learn/contribute/helping-out/reviewing-pull-requests.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Matty <[email protected]>
Objective
Centralize, and add back missing, PR merging rules to the Contributing Guide.
Solution
Put the four merging rules in the Reviewing Pull Requests page under How Pull Requests are merged. Deduplicate partial mentions of these rules, and instead direct to this section as a single source of truth.
Testing
Run
zola serve --openon thetrialdragon/clarify_pr_merge_rulesbranch, and check that the changed areas render correctly, and that Zola does indeed run.