Skip to content

Conversation

@BD103
Copy link
Member

@BD103 BD103 commented Aug 16, 2024

Unfortunately I didn't have time to catch #1600 before it was merged. The website actually uses Zola 0.18, not 0.17.2! It was updated last February in #1018.

Note how we pull in shalzz/[email protected]:

- name: "Build website"
uses: shalzz/[email protected]
env:
PAGES_BRANCH: gh-pages
BUILD_DIR: .
BUILD_ONLY: true
TOKEN: fake-secret

- name: "Build and deploy website"
if: github.repository_owner == 'bevyengine'
uses: shalzz/[email protected]
env:
PAGES_BRANCH: gh-pages
BUILD_DIR: .
TOKEN: ${{ secrets.CART_PAT }}

@BD103 BD103 added A-Meta C-Correction A typo, problem or factual issue in what we've written S-Needs-Review D-Trivial labels Aug 16, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 16, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review Ready for a maintainer to consider for merging and removed S-Needs-Review labels Aug 16, 2024
@victorb
Copy link
Contributor

victorb commented Aug 16, 2024

Ah, my bad, based it solely on a Discord comment from @alice-i-cecile (just to wash my hands clear 🤣 )

@alice-i-cecile
Copy link
Member

Yeah, that was just based on me checking what version I was running locally (which worked!). Definitely my fault!

Merged via the queue into bevyengine:main with commit 5e14fad Aug 16, 2024
@BD103
Copy link
Member Author

BD103 commented Aug 16, 2024

No worries, just trying to clear the confusion!

@BD103 BD103 deleted the zola-0.18 branch September 10, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Meta C-Correction A typo, problem or factual issue in what we've written D-Trivial S-Ready-For-Final-Review Ready for a maintainer to consider for merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants