Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nodei.co badge #5

Merged
merged 3 commits into from
Sep 19, 2016
Merged

Conversation

digitalsadhu
Copy link
Contributor

Copy link
Member

@balupton balupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't decide on nodeicoParams or nodeicoOptions, as nodeicoParams is fitting as they are query-string parameters, but really, they are optional query-string parameters, so nodeicoOptions is probably fitting.

Other option is nodeicoQueryParams or nodeicoQueryOptions in case in the future there is some other config that is needed, where we have nodeicoSomething and nodeicoOptions could be confusing as to why Something isn't inside nodeicoOptions instead of alongside it.

Perhaps nodeicoQueryString which can be string or object. That would actually work very well. Let's do that.

@digitalsadhu
Copy link
Contributor Author

Applied some fixes, how we looking?

@balupton
Copy link
Member

Merging now.

@balupton
Copy link
Member

It should be noted that the string mode is not tested. I'll add a note for this in the merge. Also tempted to call it nodeicoQueryString and just have object support, as that seems easier.

@balupton balupton merged commit d59a345 into bevry:master Sep 19, 2016
@balupton
Copy link
Member

Released to v1.2.1! 👍

@mikeumus mikeumus added the enhancement Improvement or suggestion label Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants