fromstring() --> frombytes() #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[This build](https://travis-ci.org/dib-lab/sourmash/jobs/428784272) was failing because the following error was printed too many times and Travis killed the job: ``` /home/travis/build/dib-lab/sourmash/.tox/py36/src/bamnostic/bamnostic/core.py:203: DeprecationWarning:fromstring() is deprecated. Use frombytes() instead. ``` Hopefully this passes and can be smoothly added!
5 tasks
betteridiot
reviewed
Sep 15, 2018
There was a problem hiding this comment.
From first look, this seems like an easy fix. However, it is only an easy fix for Python 3. Python 2's array.array does not have a frombytes() method, and therefore this would break those pipelines.
I will go a different way, and make a new utility class to handle the cross-compatibility.
Great catch and PR though.
|
Version v0.9.1 fixes your issue. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build was failing because the following error was printed too many times and Travis killed the job:
Hopefully this passes and can be smoothly added!