Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing debugmodes and fields #3646

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Add missing debugmodes and fields #3646

merged 3 commits into from
Nov 28, 2023

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Nov 27, 2023
@haslinghuis haslinghuis self-assigned this Nov 27, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@nerdCopter
Copy link
Member

This is a setup for future and not necessarily usable currently, correct?

@haslinghuis
Copy link
Member Author

Awaiting merge of betaflight/betaflight#13166.
Remaining fields need some work - but could be done in follow up (left todo comment in code)

@blckmn
Copy link
Member

blckmn commented Nov 27, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the add-debug branch 2 times, most recently from 54b44dd to 50286e6 Compare November 28, 2023 11:07
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
95.1% 95.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit 5fc5f51 into betaflight:master Nov 28, 2023
@haslinghuis haslinghuis deleted the add-debug branch November 28, 2023 13:43
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Add missing debugmodes and fields (betaflight#3646)
a0e7faf 
* Add missing debugmodes and fields

* Update text in setup

* Fix todo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @nerdCopter @blckmn @ctzsnooze