Skip to content

Fix attempt to fix flaky BundleSelectorPluginTest #9999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macfarla merged 2 commits into from
Mar 9, 2026
Merged

Fix attempt to fix flaky BundleSelectorPluginTest #9999

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6a6340
Fix flaky BundleSelectorPluginTest on slow CI runners
macfarla Mar 9, 2026
ccf279e
Merge branch 'main' into fix/bundle-selector-plugin-test-flaky
macfarla Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...anceTest/java/org/hyperledger/besu/tests/acceptance/plugins/BundleSelectorPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ public void bundleIsNotMinedLastTxFails() throws IOException {
"--plugin-bundle-test-enabled=true",
"--plugin-bundle-size=2",
"--plugin-bundle-failing-nonce=1",
"--plugin-block-txs-selection-max-time=75"));
"--plugin-block-txs-selection-max-time=75",
"--poa-block-txs-selection-max-time=95"));
Comment on lines 76 to +80
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max-time values (75/95) are magic numbers introduced inline. To make future tuning and consistency easier (especially across multiple tests in this class), consider extracting these values into named constants (e.g., PLUGIN_SELECTION_MAX_TIME_MS, POA_SELECTION_MAX_TIME_MS) and reusing them.

Copilot uses AI. Check for mistakes.
cluster.start(node);

// since the last tx of the bundle fails, the first was initially selected, but eventually not
Expand All @@ -95,7 +96,8 @@ public void bundleIsNotMinedMiddleTxFails() throws IOException {
"--plugin-bundle-test-enabled=true",
"--plugin-bundle-size=3",
"--plugin-bundle-failing-nonce=1",
"--plugin-block-txs-selection-max-time=75"));
"--plugin-block-txs-selection-max-time=75",
"--poa-block-txs-selection-max-time=95"));
Comment on lines 96 to +100
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: the duplicated inline timing values make it easy for these tests to drift apart unintentionally. Prefer shared constants (or a small helper that builds these common flags) so changes are made in one place.

Copilot uses AI. Check for mistakes.
cluster.start(node);

// since the last tx of the bundle fails, the first was initially selected, but eventually not
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment appears under bundleIsNotMinedMiddleTxFails(), but it says 'since the last tx of the bundle fails'. That’s misleading for the scenario being tested. Please update the comment to reflect that the failing transaction is the middle transaction (nonce 1) for this test.

Copilot uses AI. Check for mistakes.
Expand Down