Skip to content

TESTING rpc api group allowed#9946

Merged
macfarla merged 4 commits intobesu-eth:mainfrom
macfarla:add-testing-rpc-api-group
Mar 4, 2026
Merged

TESTING rpc api group allowed#9946
macfarla merged 4 commits intobesu-eth:mainfrom
macfarla:add-testing-rpc-api-group

Conversation

@macfarla
Copy link
Copy Markdown
Contributor

@macfarla macfarla commented Mar 3, 2026

PR description

This PR just adds the TESTING group to the acceptable list.
Refer to #9838 which has an early implementation of a testing endpoint

Fixed Issue(s)

latest hive run failed with

Failed to start Besu: Invalid value for option '--rpc-http-api': invalid entries found [TESTING]
Invalid value for option '--rpc-http-api': invalid entries found [TESTING]

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copilot AI review requested due to automatic review settings March 3, 2026 09:06
@macfarla macfarla added RPC hive relating to hive tests labels Mar 3, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the TESTING JSON-RPC API group to the set of accepted --rpc-http-api values to prevent startup failures when TESTING is configured.

Changes:

  • Added TESTING to the RpcApis enum so it is treated as a valid RPC API group.

@macfarla macfarla enabled auto-merge (squash) March 3, 2026 09:11
Copy link
Copy Markdown
Contributor

@matkt matkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit 5bccc70 into besu-eth:main Mar 4, 2026
50 of 65 checks passed
@macfarla macfarla deleted the add-testing-rpc-api-group branch March 4, 2026 21:36
qu0b pushed a commit to qu0b/besu that referenced this pull request Mar 16, 2026
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
qu0b pushed a commit to qu0b/besu that referenced this pull request Mar 16, 2026
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: qu0b <stefan@starflinger.eu>
macfarla added a commit that referenced this pull request Mar 17, 2026
* TESTING api group allowed (#9946)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: qu0b <stefan@starflinger.eu>

* implement testing_buildBlockV1 (#9838)

Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: qu0b <stefan@starflinger.eu>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: qu0b <stefan@starflinger.eu>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hive relating to hive tests RPC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants