StackMath #9881
StackMath #9881
Check failed
There are 9 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | 2d92991 | ENH: represent UInt256 as big-endian limbs | Valid sign-off found |
| 🟢 | 943b56a | FIX: array indices bugs for fromBytesBE and mulMod... | Valid sign-off found |
| 🟢 | 9290696 | FIX: offset indices in mulMod and fromBytesBE | Valid sign-off found |
| 🟢 | 8f512d7 | FIX: spotless | Valid sign-off found |
| 🟢 | d5e61e3 | ENH: cleaning addition and compareLimbs | Valid sign-off found |
| 🟢 | 61c809a | ENH: big-endian long limbs for UInt256 | Valid sign-off found |
| 🟢 | c8ef15e | ENH: migrated mod to record based UInt256 | Valid sign-off found |
| 🟢 | 7ba2571 | FIX: uint256 mod bugs | Valid sign-off found |
| 🟢 | 90f664f | ENH: improve on worst case fromBytesBE | Valid sign-off found |
| 🟢 | 50760c3 | FIX: spotless | Valid sign-off found |
| 🟢 | 66dc8dd | REF: records for addMod and mulMod | Valid sign-off found |
| 🟢 | 92b15c9 | FIX: spotless and mod bugs | Valid sign-off found |
| 🟢 | edf16df | FIX: tests passing | Valid sign-off found |
| 🟢 | b3812e3 | FIX: spotless | Valid sign-off found |
| 🟢 | a343f5c | ENH: use div2by1 instead of div3by2 | Valid sign-off found |
| 🟢 | 4a793b4 | FIX: spotless | Valid sign-off found |
| 🟢 | dc2ef2c | FIX: javadoc | Valid sign-off found |
| 🟢 | 6593ae4 | Merge branch 'feat/uint256-as-record' into stack_b... | Skipped: sign-off not required in merge commit |
| 🔴 | 1899bee | first batch of uint256 native stack | Sign-off not found |
| 🔴 | 0adc5df | second batch of uint256 native stack, replaced leg... | Sign-off not found |
| 🔴 | f690fc8 | fix benchmarks | Sign-off not found |
| 🔴 | 89877eb | stack unsafe methods with stack pool | Sign-off not found |
| 🔴 | ae82cad | do op code operations directly on stack without in... | Sign-off not found |
| 🔴 | 88e6391 | branch free add and sub | Sign-off not found |
| 🔴 | 429f829 | use varhandle for byte conversions | Sign-off not found |
| 🔴 | 83fa271 | bug fixes, mload and mstore improvements | Sign-off not found |
| 🔴 | 8273e34 | only use primitive byte array in memory | Sign-off not found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~27 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin stack_long_array