bal-devnet-3: Update EIP-8024: switch to new decoding algo#9851
Merged
daniellehrner merged 3 commits intoFeb 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Besu’s EIP-8024 immediate decoding to match the revised spec (new branchless decoding), and adjusts unit/acceptance tests plus devnet fixtures accordingly.
Changes:
- Updated EIP-8024 decoder tables to use the new branchless formulas for
decode_singleanddecode_pair. - Updated DUPN/SWAPN/EXCHANGE unit tests to reflect new immediate→operand mappings and end-of-code behavior.
- Updated acceptance-test dev fixtures and test documentation to use the new immediates used by the updated spec vectors.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| evm/src/main/java/org/hyperledger/besu/evm/operation/Eip8024Decoder.java | Implements the new EIP-8024 decoding formulas and updates validity ranges. |
| evm/src/test/java/org/hyperledger/besu/evm/operation/SwapNOperationTest.java | Updates SWAPN decoding/behavior expectations to match the new mapping. |
| evm/src/test/java/org/hyperledger/besu/evm/operation/DupNOperationTest.java | Updates DUPN decoding/behavior expectations to match the new mapping. |
| evm/src/test/java/org/hyperledger/besu/evm/operation/ExchangeOperationTest.java | Updates EXCHANGE decoding/behavior expectations and spec vectors for the new mapping. |
| acceptance-tests/tests/src/acceptanceTest/resources/dev/dev_amsterdam.json | Updates embedded EIP-8024 test bytecode/decompilation strings to the new immediates. |
| acceptance-tests/tests/src/acceptanceTest/java/org/hyperledger/besu/tests/acceptance/ethereum/EIP8024StackOpcodeAcceptanceTest.java | Updates explanatory comments for acceptance tests to match new spec/immediates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a73e4b6 to
ed965c2
Compare
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
ed965c2 to
5a85796
Compare
macfarla
approved these changes
Feb 23, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
EIP-8024 decoding changed to the new spec: ethereum/EIPs#11306
Fixed Issue(s)
fixes #9827
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests