Skip to content

remove fast sync from genesis tests from RunnerTest#8974

Merged
macfarla merged 1 commit intobesu-eth:mainfrom
macfarla:rm-fast-sync-test
Jul 18, 2025
Merged

remove fast sync from genesis tests from RunnerTest#8974
macfarla merged 1 commit intobesu-eth:mainfrom
macfarla:rm-fast-sync-test

Conversation

@macfarla
Copy link
Copy Markdown
Contributor

@macfarla macfarla commented Jul 18, 2025 •
edited
Loading

PR description

Remove these fast sync tests that are flaky eg https://github.com/hyperledger/besu/actions/runs/16333574965/job/46141294930?pr=8967

Fixed Issue(s)

Fast sync is deprecated per #7906 and broken per #7511

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla
remove fast sync from genesis tests
c52279c 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla added testing flake 60% of the time it works 100% of the time. labels Jul 18, 2025
pinges
pinges approved these changes Jul 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla enabled auto-merge (squash) July 18, 2025 00:39
@macfarla macfarla merged commit 38d901d into besu-eth:main Jul 18, 2025
51 checks passed
@macfarla macfarla deleted the rm-fast-sync-test branch July 23, 2025 04:37
jflo pushed a commit to jflo/besu that referenced this pull request Sep 8, 2025
@macfarla @jflo
remove fast sync from genesis tests (besu-eth#8974)
3e7c437 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo pushed a commit to jflo/besu that referenced this pull request Sep 8, 2025
@macfarla @jflo
remove fast sync from genesis tests (besu-eth#8974)
2789bc3 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinges pinges pinges approved these changes

Assignees

No one assigned

Labels

flake 60% of the time it works 100% of the time. testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macfarla @pinges