Remove PostMergeContext singleton#8253
Merged
jframe merged 9 commits intobesu-eth:mainfrom Feb 6, 2025
Merged
Conversation
Signed-off-by: Jason Frame <jason.frame@consensys.net>
jframe
force-pushed
the
removePostMergeContextSingleton
branch
from
aa48cbb to
cab9c7e
Compare
Signed-off-by: Jason Frame <jason.frame@consensys.net>
…esu into removePostMergeContextSingleton
jframe
force-pushed
the
removePostMergeContextSingleton
branch
from
011c16a to
a9eb5e2
Compare
…and expose method to access the PostMergeContext Signed-off-by: Jason Frame <jason.frame@consensys.net>
jframe
force-pushed
the
removePostMergeContextSingleton
branch
from
a9eb5e2 to
f530e77
Compare
Signed-off-by: Jason Frame <jason.frame@consensys.net>
jframe
force-pushed
the
removePostMergeContextSingleton
branch
from
f530e77 to
b8fec68
Compare
jframe
changed the title
9 tasks
Signed-off-by: Jason Frame <jason.frame@consensys.net>
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Remove the PostMergeContext singleton as this causes issues with testing Besu.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests