Not all invalid transient not selected txs should be penalized#8231
Merged
fab-10 merged 2 commits intobesu-eth:mainfrom Feb 4, 2025
Merged
Not all invalid transient not selected txs should be penalized#8231fab-10 merged 2 commits intobesu-eth:mainfrom
fab-10 merged 2 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
garyschulte
approved these changes
Feb 3, 2025
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
…eth#8231) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Until now, ff a pending tx is not selected during block creation, with a transient invalid reason, it was kept in the txpool, but was always penalized and this is not always correct, since there are some invalid reasons that are independent from the pending tx, for example in case of not enough remaining gas in the block, or because a previous pending txs from the same sender was not selected.
This PR differentiate transient reason for not selecting a pending txs, between penalizing and not, with the introduction of
TransactionSelectionResult::invalidPenalizedwhen we want to penalize the pending tx and keepingTransactionSelectionResult.invalidTransientfor when we do not want to penalize.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests