Treat timestamp as unsigned long in engine api fork validation#8221
Merged
siladu merged 1 commit intobesu-eth:mainfrom Feb 3, 2025
Merged
Treat timestamp as unsigned long in engine api fork validation#8221siladu merged 1 commit intobesu-eth:mainfrom
siladu merged 1 commit intobesu-eth:mainfrom
Conversation
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
macfarla
approved these changes
Feb 3, 2025
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
…eth#8221) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
If the timestamp is set to
> 2^63 - 1 and <= 2^64 - 1 (UnsignedLong.MAX_VALUE = 18446744073709551615), then since we use a (signed) primitive long by default this can overflow and e.g. we interpret18446744073709551615as timestamp = -1This fixes some hive tests as part of #8177