Skip to content

[MINOR] add newline to beginning of PR template#8210

Merged
macfarla merged 5 commits intobesu-eth:mainfrom
macfarla:pr-template-newline
Feb 2, 2025
Merged

[MINOR] add newline to beginning of PR template#8210
macfarla merged 5 commits intobesu-eth:mainfrom
macfarla:pr-template-newline

Conversation

@macfarla
Copy link
Copy Markdown
Contributor

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com

PR description

Add newline to separate from signed-off line
Also fixed some typos

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla changed the title add newline to beginning of PR template [MINOR] add newline to beginning of PR template Jan 31, 2025
@macfarla macfarla enabled auto-merge (squash) February 2, 2025 22:57
@macfarla macfarla merged commit 6d51821 into besu-eth:main Feb 2, 2025
pullurib pushed a commit to pullurib/besu that referenced this pull request Feb 6, 2025
* add newline to beginning of PR template

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* fix initial typo

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* fix tx typos

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
@macfarla macfarla deleted the pr-template-newline branch February 7, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants