Add transaction hash for debug trace responses#8205
Merged
matkt merged 9 commits intobesu-eth:mainfrom Feb 4, 2025
Merged
Conversation
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
ahamlat
approved these changes
Jan 30, 2025
Contributor
ahamlat
left a comment
There was a problem hiding this comment.
LGTM, just a small comment related to formatting json files in the tests.
I think it makes sens to keep existing format, unless you have a strong motivation around it.
| "id":1, | ||
| "result":{ | ||
| "txHash":"0x2d8f594c7a98a9cb3d3a21d551f68e916e7ecd767971b061f2994b9a7426fba8", | ||
| "result":{ |
Contributor
There was a problem hiding this comment.
Maybe review the format to keep is as it is and in the differences only what changes. I see that almost the whole json file changed because of the change in the format, e.g
}, {
is replaced with
},
{
Contributor
Author
There was a problem hiding this comment.
I think I will not be able to avoid that because it will change with the indentation
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
ahamlat
approved these changes
Feb 3, 2025
Contributor
|
@matkt think these might be legit failures (not flaky) |
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Contributor
Author
should be good now |
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
This PR adds the transaction hash to the response of a debug trace API. This aligns the behavior with other clients and makes debugging easier.
for debug_traceBlock* the trx hash will be displayed and for debugTraceTransaction the tx hash will not be displayed
{ "txHash":"0x49f505ed122c398287e1558275ccfcaa2d22df98df5b55e6c70635e6aa3a6ecc", "result":{ "gas":21164, "failed":false, "returnValue":"", "structLogs":[ { "pc":0, "op":"STOP", "gas":17592186023252, "gasCost":0, "depth":1 } ] }Fixed Issue(s)
fixes #8195
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests