Simulation: Add state to StateOverride (eth_call, eth_simulateV1).#8166
Merged
Gabriel-Trintinalia merged 3 commits intobesu-eth:mainfrom Feb 2, 2025
Merged
Conversation
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
macfarla
approved these changes
Feb 2, 2025
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
non-blocking suggestion
| (key, value) -> | ||
| account.setStorageValue( | ||
| UInt256.fromHexString(key), UInt256.fromHexString(value))); | ||
| }); |
Contributor
There was a problem hiding this comment.
maybe extract lines 472-475 to a method and call it for state and stateDiff - something like setStorageValues or applyStorageOverrides ...
Contributor
There was a problem hiding this comment.
or maybe 470-475 and pass a boolean for whether to clear first
macfarla
added
the
doc-change-required
bgravenorst
removed
the
doc-change-required
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
…esu-eth#8166) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
The state field functions similarly to stateDiff, but with the added functionality of clearing the storage before applying the diff map.
refs #5788