Simulation: Add nonce to call parameter#8139
Merged
Gabriel-Trintinalia merged 6 commits intobesu-eth:mainfrom Jan 20, 2025
Merged
Simulation: Add nonce to call parameter#8139Gabriel-Trintinalia merged 6 commits intobesu-eth:mainfrom
Gabriel-Trintinalia merged 6 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
…ce and encoding a new transaction with right nonce Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Gabriel-Trintinalia
added
doc-change-required
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
usmansaleem
approved these changes
Jan 20, 2025
Contributor
usmansaleem
left a comment
usmansaleem
left a comment
There was a problem hiding this comment.
LGTM - most changes are in the .json files.
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
fab-10
reviewed
Jan 20, 2025
| final long nonce = | ||
| callParams | ||
| .getNonce() | ||
| .orElse( |
Contributor
There was a problem hiding this comment.
For efficiency, should not be orElseGet to only compute it is the nonce is not present in the call params?
Contributor
Author
9 tasks
bgravenorst
removed
the
doc-change-required
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
This pull request introduces the nonce parameter to the transaction call parameters. If a nonce is specified, the simulation will use the value provided. If not, it will default to the sender's nonce.
Additionally, this PR addresses and fixes the specification tests by either:
This update ensures compatibility with Geth's transaction call object specifications: Geth Documentation.