Support authorizationList parsing in reference test txs#8116
Merged
siladu merged 5 commits intobesu-eth:mainfrom Jan 14, 2025
Merged
Support authorizationList parsing in reference test txs#8116siladu merged 5 commits intobesu-eth:mainfrom
siladu merged 5 commits intobesu-eth:mainfrom
Conversation
…ec-tests Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
siladu
commented
Jan 14, 2025
Comment on lines
-41
to
-43
| if (chainId.signum() <= 0) { | ||
| throw new IllegalArgumentException("Non positive chain id: " + chainId); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@fab-10 FYI EIP-7702 formalises chainId = 0 being allowed
See https://eips.ethereum.org/EIPS/eip-7702 and
https://ethereum-magicians.org/t/eip-2294-explicit-bound-to-chain-id/11090/29?u=siladu
Contributor
There was a problem hiding this comment.
Is chainId = 0 allowed everywhere? When I read 7702 I thought it only applied when processing the new transaction type.
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I see no harm in allowing the chainId to be zero everywhere, but instead of completely remove the validation, you can change it to only check it is not negative.
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
fab-10
approved these changes
Jan 14, 2025
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
Support authorizationList parsing in reference tests for execution-spec-tests Allow zero chainId Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports for execution-spec-tests, example:
PR description
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests