Move gas refund calculation from MainnetTransactionProcessor to GasCalculator#8106
Merged
daniellehrner merged 6 commits intobesu-eth:mainfrom Jan 14, 2025
Merged
Conversation
daniellehrner
changed the title
daniellehrner
force-pushed
the
feat/refund_calculator
branch
from
6118848 to
0b3870e
Compare
siladu
approved these changes
Jan 14, 2025
Contributor
There was a problem hiding this comment.
There's already several pieces of refund logic scattered across the GasCalculators, most recently calculateDelegateCodeGasRefund.
I think it's confusing to have refund logic both in RefundCalculator classes and in the GasCalculator classes, would prefer one or the other.
I have a slight preference for putting this logic into the GasCalculator classes since it's a smaller change than extracting all the other refund logic.
Won't block the PR on it.
Contributor
There was a problem hiding this comment.
Alternatively, if it makes sense to make this a very precise type of RefundCalculator with a precise name, then maybe it works. Not sure what that name would be and if this is sufficiently isolated enough from the other refund logic.
Contributor
Author
There was a problem hiding this comment.
@siladu I think you are right, I've moved the logic to the GasCalculator and got rid of the RefundCalculator
…dCalculator Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
daniellehrner
force-pushed
the
feat/refund_calculator
branch
from
0b3870e to
894d7b2
Compare
daniellehrner
changed the title
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
…lculator (besu-eth#8106) * move gas refund calculation from MainnetTransactionProcessor to RefundCalculator Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fix MainnetTransactionProcessorTest Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * add test for FrontierRefundCalculator Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * add test for FrontierRefundCalculator Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * add PragueRefundCalculator dummy Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * move refund logic to gas calculator, delete RefundCalculator Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Because of EIP-7623 the gas refund calculation will change with the upcoming Prague hard fork. Right now this calculation is hardcoded in
MainnetTransactionProcessor. This PR moves this calculation to theGasCalculator, which allows to change the refund calculation with a new hardfork.Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests